Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dds 1175 use presigned urls for upload #657

Closed
wants to merge 6 commits into from

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 27, 2023

Before submitting this PR

  1. Description: Add a summary of the changes in this PR and the related issue.
  2. Jira task / GitHub issue: Link to the github issue or add the Jira task ID here.
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Pylint: Python code linter. Does not execute. Only tests.
    Fix code producing warnings. Code must get 10/10.
    • Warnings fixed
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #657 (02ac9fa) into dev (799edac) will decrease coverage by 0.17%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##              dev     #657      +/-   ##
==========================================
- Coverage   46.74%   46.57%   -0.17%     
==========================================
  Files          31       31              
  Lines        2792     2800       +8     
==========================================
- Hits         1305     1304       -1     
- Misses       1487     1496       +9     
Files Coverage Δ
dds_cli/__init__.py 91.86% <100.00%> (+0.09%) ⬆️
dds_cli/data_putter.py 22.30% <16.66%> (-0.26%) ⬇️
dds_cli/file_handler_local.py 57.54% <0.00%> (-0.55%) ⬇️

... and 1 file with indirect coverage changes

@i-oden
Copy link
Member Author

i-oden commented Nov 2, 2023

Closing. Will not have time to fix.

@i-oden i-oden closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant