Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in documentation regarding password management system #711

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

valyo
Copy link
Member

@valyo valyo commented Sep 12, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

These changes clarify in the documentation that we do not provide/recommend any specific password management system and that bitwarden is just an example etc.

2. Jira task / GitHub issue

DDS-2083

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.64%. Comparing base (94ff246) to head (1136c65).
Report is 52 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #711      +/-   ##
==========================================
- Coverage   47.74%   47.64%   -0.11%     
==========================================
  Files          31       31              
  Lines        2886     2886              
==========================================
- Hits         1378     1375       -3     
- Misses       1508     1511       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valyo valyo marked this pull request as ready for review September 16, 2024 14:22
@valyo valyo requested a review from a team as a code owner September 16, 2024 14:22
docs/password.rst Outdated Show resolved Hide resolved
docs/password.rst Outdated Show resolved Hide resolved
@valyo valyo requested a review from i-oden September 20, 2024 09:01
@i-oden i-oden merged commit a5939bb into dev Sep 23, 2024
16 checks passed
@i-oden i-oden deleted the DDS-2083-clarify-passwd-management-documentation branch September 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants