Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new dev instance url to cli config #712

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Sep 18, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Added new dev instance url to cli config

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Sep 18, 2024
@rv0lt rv0lt marked this pull request as ready for review September 19, 2024 07:31
@rv0lt rv0lt requested a review from a team as a code owner September 19, 2024 07:31
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the version of the CLI as well so that it's updated on testPyPI
In version.py:

__version__ = "2.7.1-pentest"

or something like that.

dds_cli/__init__.py Outdated Show resolved Hide resolved
@rv0lt
Copy link
Member Author

rv0lt commented Sep 19, 2024

For it to be accepted with letters is can only be "dev" or "post" keywords
https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers

Change the version of the CLI as well so that it's updated on testPyPI In version.py:

__version__ = "2.7.1-pentest"

or something like that.

@i-oden
Copy link
Member

i-oden commented Sep 20, 2024

For it to be accepted with letters is can only be "dev" or "post" keywords https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers

Change the version of the CLI as well so that it's updated on testPyPI In version.py:

__version__ = "2.7.1-pentest"

or something like that.

dev as you have now is better anyway so all good

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to change the version again. Just undo the version change that you've done. TestPyPI doesn't work anyway and we won't make a new release today so the users will have to clone the dds-cli repo and use the dev branch anyway.

inaod@inaod-xps-15:~/Documents/repos/DDS/dds_cli$ dds motd ls
     ︵ 
 ︵ (  )   ︵ 
(  ) ) (  (  )   SciLifeLab Data Delivery System 
 ︶  (  ) ) (    https://dev.delivery.scilifelab.se/ 
      ︶ (  )    CLI Version 2.7.1.dev0 
          ︶
INFO     No saved token found, or token has expired, proceeding with authentication                                                                                                                                            
DDS username: sdfsdf
DDS password: 
ERROR    Failed to authenticate user: Incompatible version lengths.  

@i-oden
Copy link
Member

i-oden commented Sep 20, 2024

@rv0lt Ok to merge

@rv0lt rv0lt merged commit 7972db5 into dev Sep 20, 2024
17 checks passed
@rv0lt rv0lt deleted the DDS-2122-Add-dds-dev-url-to-CLI-config branch September 20, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants