Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v2.8.0 - No more Python 3.7 #713

Merged
merged 52 commits into from
Sep 24, 2024
Merged

New release v2.8.0 - No more Python 3.7 #713

merged 52 commits into from
Sep 24, 2024

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 20, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

New release

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

aishling-scilifelab and others added 30 commits July 29, 2024 13:49
- Currently, the testing page does not appear in the navigation panel.
This makes it hard to find and users often don't.
- The instructions as is do not work. Explain that incompatibilities
can happen.
- Add ID to installation.rst so can reference it.
…privilege-escalation-in-windows-in-dds-cli-requirements-dev-txt

Unpin pyinstaller
…ner-file-and-branch-protection-to-dds-cli

CODEOWNERS file
…n-version-in-dds_cli-to-same-as-dds_web

Bump python version in client
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.76%. Comparing base (00d1e06) to head (45e84c1).
Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
dds_cli/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files          31       31           
  Lines        2887     2889    +2     
=======================================
+ Hits         1379     1380    +1     
- Misses       1508     1509    +1     
Flag Coverage Δ
47.76% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@i-oden i-oden changed the title New release - No more Python 3.7 New release v2.8.0 - No more Python 3.7 Sep 24, 2024
@rv0lt rv0lt self-assigned this Sep 24, 2024
@rv0lt rv0lt marked this pull request as ready for review September 24, 2024 09:35
CHANGELOG.rst Outdated Show resolved Hide resolved
@i-oden i-oden requested a review from a team September 24, 2024 09:56
@rv0lt rv0lt assigned rv0lt and unassigned rv0lt Sep 24, 2024
@rv0lt
Copy link
Member

rv0lt commented Sep 24, 2024

@aishling-scilifelab Still needs approval from someone else somehow, maybe because I assigned myself to it?

@i-oden
Copy link
Member Author

i-oden commented Sep 24, 2024

@aishling-scilifelab Still needs approval from someone else somehow, maybe because I assigned myself to it?

For me it says it's ok to merge (Also Aishling is on holiday).
Since it's all been previously approved in PRs, I will merge now.

@i-oden i-oden merged commit b9d3fd3 into master Sep 24, 2024
16 checks passed
@rv0lt
Copy link
Member

rv0lt commented Sep 24, 2024

@aishling-scilifelab Still needs approval from someone else somehow, maybe because I assigned myself to it?

For me it says it's ok to merge (Also Aishling is on holiday). Since it's all been previously approved in PRs, I will merge now.

Uh sorry, I meant to ping you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants