Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dds motd send command #720

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Oct 17, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Fix the client command after post merge feedback

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Oct 17, 2024
dds_cli/__main__.py Outdated Show resolved Hide resolved
Co-authored-by: Ina Odén Österbo <[email protected]>
@rv0lt rv0lt marked this pull request as ready for review October 18, 2024 09:18
@rv0lt rv0lt requested a review from a team as a code owner October 18, 2024 09:18
@rv0lt rv0lt requested a review from i-oden October 18, 2024 09:18
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ok to merge

@valyo valyo merged commit aaef026 into dev Oct 22, 2024
17 checks passed
@valyo valyo deleted the DDS-2153-Update-dds-motd-send-command-Ina-s-review branch October 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants