SS-606, SS-534 - adjust default flavor, make two project templates #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to enable chart rendering
…om:ScilifelabDataCentre/stackn into SS-308-add-security-contexts-to-all-charts
…om:ScilifelabDataCentre/stackn into SS-308-add-security-contexts-to-all-charts
akochari
requested review from
churnikov,
hamzaimran08,
alfredeen and
sandstromviktor
akochari
added
enhancement
sandstromviktor
approved these changes
Oct 11, 2023
Comment on lines
+101
to
+123
|
|
||
| }) | ||
|
|
||
| Cypress.Commands.add('deleteBlankProject', (project_name) => { | ||
|
|
||
| cy.visit("/projects/") | ||
|
|
||
| cy.get('h5.card-title').contains(project_name).siblings('div').find('a.confirm-delete').click() | ||
| .then((href) => { | ||
| cy.get('div#modalConfirmDelete').should('have.css', 'display', 'block') | ||
|
|
||
| cy.get("h1#modalConfirmDeleteLabel").then(function($elem) { | ||
| cy.log($elem.text()) | ||
|
|
||
| cy.get('div#modalConfirmDeleteFooter').find('button').contains('Delete').click() | ||
|
|
||
| // Assert that the project has been deleted | ||
| cy.contains(project_name).should('not.exist') | ||
| }) | ||
| }) | ||
|
|
||
| }) |
There was a problem hiding this comment.
I like this. We should do more functions like this and reuse throughout tests.
Comment on lines
+134
to
136
| <label class="form-label">Hardware</label> | ||
| <span class="bi bi-question-circle" style="color: #989da0" data-bs-toggle="tooltip" title="" data-bs-placement="right" data-bs-original-title="Hardware allocation for your app. Only one option is available by default. If your app requires more hardware resources, get in touch with us ([email protected]) with a request."> | ||
| </span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two project templates as per SS-534 + hidden the cards to create ML-related apps from the project dashboard. Adjusted the default flavor name, assigned resources, made that Hardware in UI - SS-606. Logged in users now see the projects index unless they explicitly ask for homepage - SS-595. Additionally, fixes failing e2e tests from previous PR, adjusts e2e tests. A few small changes. I also noticed that now it takes a bit longer to create a project so added waiting time for this step in the tests.
There is a corresponding PR in the serve-charts repo.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!