-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS-606, SS-534 - adjust default flavor, make two project templates #77
Conversation
…es to enable chart rendering
…om:ScilifelabDataCentre/stackn into SS-308-add-security-contexts-to-all-charts
…om:ScilifelabDataCentre/stackn into SS-308-add-security-contexts-to-all-charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good and important fixes! Great job!
|
||
}) | ||
|
||
Cypress.Commands.add('deleteBlankProject', (project_name) => { | ||
|
||
cy.visit("/projects/") | ||
|
||
cy.get('h5.card-title').contains(project_name).siblings('div').find('a.confirm-delete').click() | ||
.then((href) => { | ||
cy.get('div#modalConfirmDelete').should('have.css', 'display', 'block') | ||
|
||
cy.get("h1#modalConfirmDeleteLabel").then(function($elem) { | ||
cy.log($elem.text()) | ||
|
||
cy.get('div#modalConfirmDeleteFooter').find('button').contains('Delete').click() | ||
|
||
// Assert that the project has been deleted | ||
cy.contains(project_name).should('not.exist') | ||
}) | ||
}) | ||
|
||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. We should do more functions like this and reuse throughout tests.
<label class="form-label">Hardware</label> | ||
<span class="bi bi-question-circle" style="color: #989da0" data-bs-toggle="tooltip" title="" data-bs-placement="right" data-bs-original-title="Hardware allocation for your app. Only one option is available by default. If your app requires more hardware resources, get in touch with us ([email protected]) with a request."> | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Description
Added two project templates as per SS-534 + hidden the cards to create ML-related apps from the project dashboard. Adjusted the default flavor name, assigned resources, made that Hardware in UI - SS-606. Logged in users now see the projects index unless they explicitly ask for homepage - SS-595. Additionally, fixes failing e2e tests from previous PR, adjusts e2e tests. A few small changes. I also noticed that now it takes a bit longer to create a project so added waiting time for this step in the tests.
There is a corresponding PR in the serve-charts repo.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!