[email protected]: update to version 2024.5 #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GitHub The GitHub repo for the Mullvad VPN app is for all platforms and the different platforms can have separate releases, updating what "latest" points to (e.g. `android/2024.4`), leading checkver to fail. This commit changes checkver to use the Mullvad API to query directly for the latest version for Windows.
|
/verify |
|
All changes look good. Wait for review from human collaborators. mullvadvpn-np
|
1 similar comment
|
All changes look good. Wait for review from human collaborators. mullvadvpn-np
|
1 task
Refresh of installer arguments in order to: * support silent installs in both user and global contexts => `SUPPRESSMSGBOXES` will let the installer assume local user install if it does not have admin rights instead of asking for elevated privileges * get rid of a post_install error in case of local user install (because 'pgAdmin 4' folder can't be located under the common start menu) by using `NOICONS` during install instead of trying to remove start menu icons after the fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327 #306 #305 #290 #336
Reason for Change
Mullvad has changed some of URLs, since they've added Mullvad Browser. So the checkver would fail due to hitting a redirect URL (e.g., see check for #327).
But, I've figured rather than changing it to the new URL I could change the manifest to use the GitHub checkver, which should hopefully avoid any future breaking changes.The GitHub repo for the Mullvad VPN app is for all platforms and the different platforms can have separate releases, updating what "latest" points to (e.g.android/2024.4), leading checkver to fail. So, I've changed checkver to use the Mullvad API to query directly for the latest version for Windows.Summary of Changes
install.scriptanduninstall.script, respectively - this seemed like a more appropriate place for these scripts.checkverto use the Mullvad API to query for the version and extract it usingjsonpath