Change to 12 hour voting delay

[jferas]

As requested by Radworks, a 12 hour voting delay at deployment

[jferas]

Current dependencies on/for this PR:

• main
  • PR Change to 12 hour voting delay #23 👈

This stack of pull requests is managed by Graphite.

[github-actions]

Coverage after merging voting-delay-12-hours into main will be

76.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
RadworksGovernor.sol	73.91%	75%	69.23%	76%	101, 126–127, 135, 138, 152, 203, 84

[wildmolasses]

is the clock mode on this contract blocks or timestamp? in either case, is this correct?

[jferas]

Blocks... the RadworksGovernor inherits from GovernorVotesComp, and GovernorVotesComp defines its clock function in such as way that if the underlying governance token has a clock function, that it called and its value is returned.. if it does not (and the Radicle token does not) the current block number is returned:

(from GovernorVotesComp)
   /**
     * @dev Clock (as specified in EIP-6372) is set to match the token's clock. Fallback to block numbers if the token
     * does not implement EIP-6372.
     */
    function clock() public view virtual override returns (uint48) {
        try token.clock() returns (uint48 timepoint) {
            return timepoint;
        } catch {
            return SafeCast.toUint48(block.number);
        }
    }

At 12 seconds per block (5 per minute) an hour's worth of blocks would be 300 .. so 12 hours would be 3600.

[wildmolasses]

thanks for the explanation @jferas, i stand corrected, looks good to me!