Initial tests and architecture

.env.template

@@ -0,0 +1,3 @@
+DEPLOYER_PRIVATE_KEY=
+PROPOSER_PRIVATE_KEY=
+MAINNET_RPC_URL=

.github/workflows/ci.yml

@@ -9,6 +9,7 @@ on:
 
 env:
   FOUNDRY_PROFILE: ci
+  MAINNET_RPC_URL: ${{ secrets.MAINNET_RPC_URL }}
 
 jobs:
   build:

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "lib/openzeppelin-contracts"]
 	path = lib/openzeppelin-contracts
 	url = https://github.com/openzeppelin/openzeppelin-contracts
+[submodule "lib/solmate"]
+	path = lib/solmate
+	url = https://github.com/transmissions11/solmate

foundry.toml

@@ -2,7 +2,10 @@
   evm_version = "paris"
   optimizer = true
   optimizer_runs = 10_000_000
-  remappings = ["@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts"]
+  remappings = [
+    "@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts",
+    "@solmate/utils/=lib/solmate/src/utils",
+  ]
   solc_version = "0.8.20"
   verbosity = 3
 
@@ -16,6 +19,9 @@
   # Speed up compilation and tests during development.
   optimizer = false
 
+[rpc_endpoints]
+  mainnet = "${MAINNET_RPC_URL}"
+
 [fmt]
   bracket_spacing = false
   int_types = "long"

script/Deploy.s.sol

@@ -1,16 +1,26 @@
-// SPDX-License-Identifier: UNLICENSED
-// slither-disable-start reentrancy-benign
-
-pragma solidity 0.8.20;
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity ^0.8.20;
 
 import {Script} from "forge-std/Script.sol";
-import {Counter} from "src/Counter.sol";
+import {DeployInput} from "script/DeployInput.sol";
+import {RadworksGovernor} from "src/RadworksGovernor.sol";
+
+contract Deploy is DeployInput, Script {
+  uint256 deployerPrivateKey;
+
+  function setUp() public {
+    deployerPrivateKey = vm.envOr(
+      "DEPLOYER_PRIVATE_KEY",
+      uint256(0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80)
+    );
+  }
 
-contract Deploy is Script {
-  Counter counter;
+  function run() public returns (RadworksGovernor) {
+    vm.startBroadcast(deployerPrivateKey);
+    RadworksGovernor _governor =
+      new RadworksGovernor(INITIAL_VOTING_DELAY, INITIAL_VOTING_PERIOD, INITIAL_PROPOSAL_THRESHOLD);
+    vm.stopBroadcast();
 
-  function run() public {
-    vm.broadcast();
-    counter = new Counter();
+    return _governor;
   }
 }

script/DeployInput.sol

@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity ^0.8.20;
+
+contract DeployInput {
+  uint256 constant INITIAL_VOTING_DELAY = 7200; // 24 hours
+  uint256 constant INITIAL_VOTING_PERIOD = 17_280; // matches existing config
+  uint256 constant INITIAL_PROPOSAL_THRESHOLD = 1_000_000e18; // matches existing config
+}

script/Propose.s.sol

@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity ^0.8.20;
+
+import {Script} from "forge-std/Script.sol";
+import {ICompoundTimelock} from
+  "@openzeppelin/contracts/governance/extensions/GovernorTimelockCompound.sol";
+
+import {RadworksGovernor} from "src/RadworksGovernor.sol";
+import {IGovernorAlpha} from "src/interfaces/IGovernorAlpha.sol";
+import {Constants} from "test/Constants.sol";
+
+/// @notice Script to submit the proposal to upgrade Radworks governor.
+contract Propose is Script, Constants {
+  IGovernorAlpha constant RADWORK_GOVERNOR_ALPHA = IGovernorAlpha(GOVERNOR_ALPHA);
+  address PROPOSER_ADDRESS = 0x464D78a5C97A2E2E9839C353ee9B6d4204c90B0b; // cloudhead.eth
+
+  function propose(RadworksGovernor _newGovernor) internal returns (uint256 _proposalId) {
+    address[] memory _targets = new address[](2);
+    uint256[] memory _values = new uint256[](2);
+    string[] memory _signatures = new string[](2);
+    bytes[] memory _calldatas = new bytes[](2);
+
+    _targets[0] = RADWORK_GOVERNOR_ALPHA.timelock();
+    _values[0] = 0;
+    _signatures[0] = "setPendingAdmin(address)";
+    _calldatas[0] = abi.encode(address(_newGovernor));
+
+    _targets[1] = address(_newGovernor);
+    _values[1] = 0;
+    _signatures[1] = "__acceptAdmin()";
+    _calldatas[1] = "";
+
+    return RADWORK_GOVERNOR_ALPHA.propose(
+      _targets, _values, _signatures, _calldatas, "Upgrade to Governor Bravo"
+    );
+  }
+
+  /// @dev After the new Governor is deployed on mainnet, `_newGovernor` can become a const
+  function run(RadworksGovernor _newGovernor) public returns (uint256 _proposalId) {
+    // The expectation is the key loaded here corresponds to the address of the `proposer` above.
+    // When running as a script, broadcast will fail if the key is not correct.
+    uint256 _proposerKey = vm.envOr(
+      "PROPOSER_PRIVATE_KEY",
+      uint256(0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d)
+    );
+    vm.rememberKey(_proposerKey);
+
+    vm.startBroadcast(PROPOSER_ADDRESS);
+    _proposalId = propose(_newGovernor);
+    vm.stopBroadcast();
+    return _proposalId;
+  }
+}

src/RadworksGovernor.sol

@@ -47,11 +47,8 @@ contract RadworksGovernor is
   /// @notice Human readable name of this Governor.
   string private constant GOVERNOR_NAME = "Radworks Governor Bravo";
 
-  /// @notice The number of RAD (in "wei") that must participate in a vote for it to meet quorum
-  /// threshold.
-  ///
-  /// TODO: placeholder
-  uint256 private constant QUORUM = 100_000e18; // 100,000 RAD
+  /// @notice The number of RAD (in "wei") that must participate in a vote to meet quorum threshold.
+  uint256 private constant QUORUM = 4_000_000e18; // 4,000,000 RAD
 
   /// @param _initialVotingDelay The initial voting delay this Governor will enforce.
   /// @param _initialVotingPeriod The initial voting period this Governor will enforce.
@@ -113,7 +110,7 @@ contract RadworksGovernor is
 
   /// @inheritdoc Governor
   function _voteSucceeded(uint256 proposalId) internal view virtual override returns (bool) {
-    ProposalVote storage proposalVote = _proposalVotes[proposalId];
+    ProposalVote memory proposalVote = _proposalVotes[proposalId];
 
     return proposalVote.forVotes > proposalVote.againstVotes;
   }

src/interfaces/IGovernorAlpha.sol

@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity >=0.8.0;
+
+interface IGovernorAlpha {
+  event ProposalCanceled(uint256 id);
+  event ProposalCreated(
+    uint256 id,
+    address proposer,
+    address[] targets,
+    uint256[] values,
+    string[] signatures,
+    bytes[] calldatas,
+    uint256 startBlock,
+    uint256 endBlock,
+    string description
+  );
+  event ProposalExecuted(uint256 id);
+  event ProposalQueued(uint256 id, uint256 eta);
+  event VoteCast(address voter, uint256 proposalId, bool support, uint256 votes);
+
+  struct Receipt {
+    bool hasVoted;
+    bool support;
+    uint96 votes;
+  }
+
+  function BALLOT_TYPEHASH() external view returns (bytes32);
+  function DOMAIN_TYPEHASH() external view returns (bytes32);
+  function cancel(uint256 proposalId) external;
+  function castVote(uint256 proposalId, bool support) external;
+  function castVoteBySig(uint256 proposalId, bool support, uint8 v, bytes32 r, bytes32 s) external;
+  function execute(uint256 proposalId) external payable;
+  function getActions(uint256 proposalId)
+    external
+    view
+    returns (
+      address[] memory targets,
+      uint256[] memory values,
+      string[] memory signatures,
+      bytes[] memory calldatas
+    );
+  function getReceipt(uint256 proposalId, address voter) external view returns (Receipt memory);
+  function latestProposalIds(address) external view returns (uint256);
+  function name() external view returns (string memory);
+  function proposalCount() external view returns (uint256);
+  function proposalMaxOperations() external pure returns (uint256);
+  function proposalThreshold() external pure returns (uint256);
+  function proposals(uint256)
+    external
+    view
+    returns (
+      address proposer,
+      uint256 eta,
+      uint256 startBlock,
+      uint256 endBlock,
+      uint256 forVotes,
+      uint256 againstVotes,
+      bool canceled,
+      bool executed
+    );
+  function propose(
+    address[] memory targets,
+    uint256[] memory values,
+    string[] memory signatures,
+    bytes[] memory calldatas,
+    string memory description
+  ) external returns (uint256);
+  function queue(uint256 proposalId) external;
+  function quorumVotes() external pure returns (uint256);
+  function state(uint256 proposalId) external view returns (uint8);
+  function timelock() external view returns (address);
+  function votingDelay() external pure returns (uint256);
+  function votingPeriod() external pure returns (uint256);
+}

test/Constants.sol

@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity ^0.8.20;
+
+contract Constants {
+  address constant GOVERNOR_ALPHA = 0x690e775361AD66D1c4A25d89da9fCd639F5198eD;
+  address payable constant RAD_TOKEN = payable(0x31c8EAcBFFdD875c74b94b077895Bd78CF1E64A3);
+  address constant TIMELOCK = 0x8dA8f82d2BbDd896822de723F55D6EdF416130ba;
+
+  // TODO: resolve the list of large delegates with tallyaddress
+  address constant PROPOSER = 0x464D78a5C97A2E2E9839C353ee9B6d4204c90B0b;
+
+  address constant USDC_ADDRESS = 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48;
+  address constant GTC_ADDRESS = 0xDe30da39c46104798bB5aA3fe8B9e0e1F348163F;
+  address constant WETH_ADDRESS = 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2;
+  address constant MTV_ADDRESS = 0x6226e00bCAc68b0Fe55583B90A1d727C14fAB77f;
+  uint256 constant MAX_REASONABLE_TIME_PERIOD = 302_400; // 6 weeks assume a 12 sec block time
+
+  // we have not yet deployed the Radworks Bravo Governor
+  address constant DEPLOYED_BRAVO_GOVERNOR = 0x1111111111111111111111111111111111111111;
+
+  uint256 constant QUORUM = 4_000_000e18;
+}