Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update salt and license #10

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Update salt and license #10

merged 2 commits into from
Mar 18, 2024

Conversation

garyghayrat
Copy link
Member

@garyghayrat garyghayrat commented Mar 5, 2024 •
edited
Loading

With the following salt params:

  bytes32 ERC5564Salt = 0xd0103a290d760f027c9ca72675f5121d725397fb2f618f05b6c44958b25b4447;
  bytes32 ERC6538Salt = 0x0883790c70e6bce521db2517ae9873b2627580f5945fb2026117ab9d15ba9387;

The resulting contract addresses will be:

      "contractName": "ERC5564Announcer",
      "contractAddress": "0x55649E01B5Df198D18D95b5cc5051630cfD45564",
      "contractName": "ERC6538Registry",
      "contractAddress": "0x65385Cebb86e6742F29868BDdE0D1980060a6538"

@garyghayrat garyghayrat requested a review from apbendi March 5, 2024 20:30
@github-actions GitHub Actions
Copy link

Coverage after merging update-license-and-deploy-script into add-signature-check-and-emit-event will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ERC5564Announcer.sol100%100%100%100%
   ERC6538Registry.sol96.67%75%100%100%95

@garyghayrat garyghayrat merged commit 9837778 into add-signature-check-and-emit-event Mar 18, 2024
6 checks passed
garyghayrat added a commit that referenced this pull request Apr 24, 2024
@garyghayrat
Add signature malleability test, emit an event when incrementNonce …
e62ebe9 
…is called, and add deployment receipts (#9)

* Add signature malleability check and emit an event when `incrementNonce` is called

* Update `IERC6538Registry`

* Remove sig check to increase compatibility with crypto libs

* Add test where a manipulated signature is used to register the same `stealthMetaAddress`

* Update test name

* Update salt, deploy script, and license (#10)

* Update salt and license

* Add broadcast receipts

* Add broadcast receipts for arbitrum-sepolia, optimism-sepolia, and base-sepolia

* Hash `stealthMetaAddress` in `dataHash`

* Update salt and add new deploy receipts

* Add holesky deployment receipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apbendi apbendi Awaiting requested review from apbendi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garyghayrat