Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume minSend amounts on frontend #319

Merged
merged 16 commits into from
Apr 13, 2022
Merged

Consume minSend amounts on frontend #319

merged 16 commits into from
Apr 13, 2022

Conversation

davidlaprade
Copy link
Contributor

@davidlaprade davidlaprade commented Apr 2, 2022 •
edited
Loading

Consume the minSend amounts that are sent by the backend and use them for frontend validation. Values from the backend are rounded so as to not be weirdly specific for the user.

frontend-min-send-amounts

@davidlaprade davidlaprade changed the title [wip] Consume minSend amounts on frontend Consume minSend amounts on frontend Apr 4, 2022
mds1
mds1 reviewed Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just want to note that I'd prefer if we can merge #293 before this one, just in case there's merge conflicts or anything since I think #293 is more "sensitive"

frontend/src/components/models.ts Outdated Show resolved Hide resolved
frontend/src/components/models.ts Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Show resolved Hide resolved
frontend/src/utils/relayer.ts Outdated Show resolved Hide resolved
frontend/src/utils/relayer.ts Outdated Show resolved Hide resolved
@davidlaprade
Expand response types to include minSendAmounts
592e746
@davidlaprade
Expand the ITXRelayer model to expose minSend amounts
6948750
@davidlaprade
Display backend minSend amounts in frontend validation messages
f72fc7e
@davidlaprade
Humanize the minSend amount before displaying it
54c0f5f
@davidlaprade
yarn prettier
6300ed5
@davidlaprade
Improve naming of extended TokenInfo type
c8daae8
@davidlaprade
Refactor for readability
b31c078
@davidlaprade
Rename ITXRelayer and associated types to make more generic
453b49f 
We aren't using ITX anymore
@davidlaprade
Update fallback values for fees
65c4bb3
@davidlaprade
Add a useWallet.chainId value
4f8026b 
It will be a miracle if this did not introduce a bug or three
@davidlaprade
Treat the native token like all other tokens in the store
d2742bb
@davidlaprade
Rename Relayer -> UmbraApi
e56d331
@davidlaprade
Fix frontend errors
707a7e5
@davidlaprade
Gracefully handle network changes in AccountSend
a43a356
@davidlaprade
Run yarn lint + prettier
08e04dd
@davidlaprade davidlaprade requested a review from mds1 April 8, 2022 14:31
mds1
mds1 reviewed Apr 11, 2022
View reviewed changes
frontend/src/components/AccountReceiveTable.vue Show resolved Hide resolved
frontend/src/components/models.ts Show resolved Hide resolved
frontend/src/utils/umbra_api.ts Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/store/wallet.ts Outdated Show resolved Hide resolved
frontend/src/store/wallet.ts Show resolved Hide resolved
frontend/src/store/wallet.ts Outdated Show resolved Hide resolved
frontend/src/utils/umbra_api.ts Outdated Show resolved Hide resolved
@mds1 mds1 mentioned this pull request Apr 12, 2022
Closed
apbendi
apbendi approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well. Thanks @davidlaprade 👍

@apbendi apbendi merged commit 08130c0 into master Apr 13, 2022
@apbendi apbendi deleted the consume-minsend-amounts branch October 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlaprade @apbendi @mds1