Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsorted state #542

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Remove unsorted state #542

merged 1 commit into from
Jun 26, 2023

Conversation

alexkeating
Copy link
Collaborator

Description

  • Sort order does not become confused when the unsorted state is removed

Closes #540

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 4239f51
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/6499a54f0b01cd00083fc0eb
😎 Deploy Preview https://deploy-preview-542--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alexkeating alexkeating marked this pull request as ready for review June 20, 2023 00:49
Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions
Copy link

Coverage after merging bug/fix-sort into master will be

85.46%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%96
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts75%73.68%66.67%76.67%11, 11, 20–21, 32, 39, 39, 43, 47, 56, 60, 8
   Umbra.ts76.67%64.67%83.33%83.81%125, 128–129, 150, 224–226, 310–313, 375, 383, 383–385, 387, 389, 409, 409, 409–410, 414, 417, 438, 455–456, 538, 555, 568–569, 579–580, 593, 596–597, 627–628, 704, 708, 708, 708–711, 711, 711, 711, 711, 711, 711–712, 712, 712, 712, 712, 712, 712, 712, 712, 712, 712, 714, 714, 714–715, 718, 718, 718, 718, 718–719, 722, 729, 729, 738, 742, 742, 742–743, 756, 760, 763–764, 770–772, 779, 779, 779–782, 813, 818–819, 819–820, 98
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts80.65%71.67%86.67%86.29%107–109, 111–113, 119, 137–138, 167, 185, 238, 264, 266–267, 276, 276, 276–277, 279, 282, 291–292, 336, 336, 336, 356, 385, 387, 392, 404, 404–405, 410, 412–413, 424–428, 434, 436, 478–479, 479, 479–481, 481, 481, 57–58, 581, 586, 83, 91, 91
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #550 to track amount based sorting improvements. Otherwise LGTM!

@apbendi apbendi merged commit 466d7af into master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting Behavior on the Receive Table is Broken & Unpredictable
4 participants