Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider so copy works again #544

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add provider so copy works again #544

merged 1 commit into from
Jun 27, 2023

Conversation

alexkeating
Copy link
Collaborator

Description

  • Fix copy behavior on the receive table

Closes #501

@alexkeating alexkeating requested a review from mds1 June 23, 2023 00:12
@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit c1d984a
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/649acd15507cca00086c34f4
😎 Deploy Preview https://deploy-preview-544--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working again!

Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed it works

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a rebase before merging @alexkeating

@github-actions
Copy link

Coverage after merging bug/fix-copy-btn into master will be

85.46%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%96
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts75%73.68%66.67%76.67%11, 11, 20–21, 32, 39, 39, 43, 47, 56, 60, 8
   Umbra.ts76.67%64.67%83.33%83.81%125, 128–129, 150, 224–226, 310–313, 375, 383, 383–385, 387, 389, 409, 409, 409–410, 414, 417, 438, 455–456, 538, 555, 568–569, 579–580, 593, 596–597, 627–628, 704, 708, 708, 708–711, 711, 711, 711, 711, 711, 711–712, 712, 712, 712, 712, 712, 712, 712, 712, 712, 712, 714, 714, 714–715, 718, 718, 718, 718, 718–719, 722, 729, 729, 738, 742, 742, 742–743, 756, 760, 763–764, 770–772, 779, 779, 779–782, 813, 818–819, 819–820, 98
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts80.65%71.67%86.67%86.29%107–109, 111–113, 119, 137–138, 167, 185, 238, 264, 266–267, 276, 276, 276–277, 279, 282, 291–292, 336, 336, 336, 356, 385, 387, 392, 404, 404–405, 410, 412–413, 424–428, 434, 436, 478–479, 479, 479–481, 481, 481, 57–58, 581, 586, 83, 91, 91
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

@mds1 mds1 merged commit 9de35f3 into master Jun 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying the Stealth Receiver and Sender Address in Receive Table is broken
4 participants