Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan from user registered block #549

Merged
merged 12 commits into from
Jul 7, 2023
Merged

Conversation

garyghayrat
Copy link
Member

@garyghayrat garyghayrat commented Jun 26, 2023

One of the improvements listed in #266

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 80c8bf1
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/64a8753666bfb40008cc658b
😎 Deploy Preview https://deploy-preview-549--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from a3c0cca to 3bb43ed Compare June 26, 2023 15:56
@garyghayrat garyghayrat changed the title Scan from user registered block number Scan from user registered block Jun 26, 2023
@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from b6ea200 to b58e13d Compare June 27, 2023 16:30
@garyghayrat garyghayrat requested a review from mds1 June 27, 2023 17:20
@garyghayrat garyghayrat marked this pull request as ready for review June 27, 2023 17:21
umbra-js/src/utils/utils.ts Outdated Show resolved Hide resolved
umbra-js/src/classes/Umbra.ts Outdated Show resolved Hide resolved
frontend/src/pages/AccountReceive.vue Outdated Show resolved Hide resolved
umbra-js/src/utils/utils.ts Outdated Show resolved Hide resolved
umbra-js/src/classes/Umbra.ts Outdated Show resolved Hide resolved
@garyghayrat garyghayrat requested a review from mds1 June 29, 2023 16:11
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far @garyghayrat, this will be a big UX boost. Identified some edge cases in initial testing.

frontend/src/pages/AccountReceive.vue Show resolved Hide resolved
frontend/src/pages/AccountReceive.vue Show resolved Hide resolved
@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from 82d981c to 0faa368 Compare July 3, 2023 16:31
@garyghayrat garyghayrat requested a review from apbendi July 3, 2023 18:22
@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from 62605e0 to 1b96c9c Compare July 6, 2023 16:49
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working, for me

@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from 1b96c9c to 5725cc9 Compare July 7, 2023 20:14
@garyghayrat garyghayrat force-pushed the scan-from-user-registered-block branch from 5725cc9 to 80c8bf1 Compare July 7, 2023 20:27
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Coverage after merging scan-from-user-registered-block into master will be

84.19%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%96
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts74.35%61.63%81.08%82.07%102, 128, 131–132, 153, 227–229, 313–316, 378, 386, 386–388, 390, 392, 409, 411, 413, 413, 413–414, 414, 414–415, 415, 415–416, 430, 430, 430–431, 435, 438, 459, 476–477, 559, 576, 589–590, 600–601, 614, 617–618, 648–649, 725, 729, 729, 729–732, 732, 732, 732, 732, 732, 732–733, 733, 733, 733, 733, 733, 733, 733, 733, 733, 733, 735, 735, 735–736, 739, 739, 739, 739, 739–740, 743, 750, 750, 759, 763, 763, 763–764, 777, 781, 784–785, 791–793, 800, 800, 800–803, 834, 839–840, 840–841
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts77.47%68.25%81.25%83.52%107–109, 111–113, 119, 137–138, 167, 185, 238, 245–249, 249, 249, 249, 249, 249, 249–250, 273, 275–276, 285, 285, 285–286, 288, 291, 300–301, 345, 345, 345, 365, 394, 396, 401, 413, 413–414, 419, 421–422, 433–437, 443, 445, 487–488, 488, 488–490, 490, 490, 57–58, 590, 595, 83, 91, 91
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @garyghayrat. Will be a big UX improvement for users.

@apbendi apbendi merged commit 6d27f3a into master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants