Sort amount correctly

[alexkeating]

Description

• Sort amount by real value

Closes #550

[netlify]

✅ Deploy Preview for jolly-shaw-20fe62 ready!

Name	Link
🔨 Latest commit	f7d332d
🔍 Latest deploy log	https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/649df6b0a461360008e1e9a1
😎 Deploy Preview	https://deploy-preview-556--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alexkeating]

FYI, I don't have an account with all the varieties of tokens in @apbendi's example, but this seems to be working with a single token. If anyone has test tokens they want to send me on Sepolia I can test with more.

[github-actions]

Coverage after merging bug/number-sorting into master will be

85.56%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
contracts-periphery/src
UmbraBatchSend.sol	93.55%	100%	75%	94.74%	96
UniswapWithdrawHook.sol	77.78%	100%	50%	80%	44
umbra-js/src
ethers.ts	88.24%	100%	78.57%	100%
types.ts	50%	100%	0%	100%
umbra-js/src/classes
KeyPair.ts	98.65%	96.49%	100%	100%	31–32
RandomNumber.ts	100%	100%	100%	100%
StealthKeyRegistry.ts	100%	100%	100%	100%
TxHistoryProvider.ts	77.55%	76.47%	66.67%	79.31%	11, 11, 19–20, 31, 38, 44, 53, 57, 8
Umbra.ts	76.51%	64.24%	83.33%	83.74%	122, 125–126, 147, 221–223, 307–310, 372, 380, 380–382, 384, 386, 406, 406, 406–407, 411, 414, 435, 452–453, 535, 552, 565–566, 576–577, 590, 593–594, 624–625, 701, 705, 705, 705–708, 708, 708, 708, 708, 708, 708–709, 709, 709, 709, 709, 709, 709, 709, 709, 709, 709, 711, 711, 711–712, 715, 715, 715, 715, 715–716, 719, 726, 726, 735, 739, 739, 739–740, 753, 757, 760–761, 767–769, 776, 776, 776–779, 810, 815–816, 816–817, 96
umbra-js/src/utils
cns.ts	50%	33.33%	50%	55%	33–36, 40, 40, 40, 40, 40–41, 44–46
constants.ts	100%	100%	100%	100%
ens.ts	36.11%	25%	33.33%	40%	25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
utils.ts	80.65%	71.67%	86.67%	86.29%	107–109, 111–113, 119, 137–138, 167, 185, 238, 264, 266–267, 276, 276, 276–277, 279, 282, 291–292, 336, 336, 336, 356, 385, 387, 392, 404, 404–405, 410, 412–413, 424–428, 434, 436, 478–479, 479, 479–481, 481, 481, 57–58, 581, 586, 83, 91, 91
umbra-js/test
testPrivateKeys.ts	100%	100%	100%	100%
utils.ts	100%	100%	100%	100%

[mds1]

If anyone has test tokens they want to send me on Sepolia I can test with more.

The DAI and USDC tokens we use on sepolia can be minted by anyone, so you can mint as much as you want to your wallet: https://github.com/ScopeLift/umbra-api/blob/9631aa785eae26e0a9b5df58bf95ad3b4cbde6ce/src/constants/tokens.ts#L10-L11

[alexkeating]

Tested with multiple tokens and seems to be working

[mds1]

code seems right to me

[apbendi]

Looks good, working well. Thanks!