Update to [email protected], [email protected], [email protected] & volta-cli/action@v4

[garyghayrat]

1. In addition to the packages mentioned in the title, we're now using the new @typechain/hardhat package instead of the archieved hardhat-typechain.

2. We're using hardhat version 2.17.1 in umbra-js and using hardhat versions ^2.17.1 in contracts-core to avoid the error that we get when both are set to ^2.17.1, which is when yarn test is run inside umbra-js:

yarn test
yarn run v1.22.18
$ yarn build && yarn hardhat test
$ tsc --build
$ /Users/user/github/umbra-protocol/node_modules/.bin/hardhat test
Error HH12: Trying to use a non-local installation of Hardhat, which is not supported.
Please install Hardhat locally using npm or Yarn, and try again.

For more info go to https://hardhat.org/HH12 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

3. Updated a few lines in Umbra.ts, Umbra.test.ts to use the new naming convention in typechain files.

[netlify]

✅ Deploy Preview for jolly-shaw-20fe62 ready!

Name	Link
🔨 Latest commit	92de58d
🔍 Latest deploy log	https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/64cd1ddc9c5cb3000857462f
😎 Deploy Preview	https://deploy-preview-577--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alexkeating]

I think we can remove these unknowns

[github-actions]

Coverage after merging chore/update-node-version into master will be

83.82%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
contracts-periphery/src
UmbraBatchSend.sol	93.55%	100%	75%	94.74%	96
UniswapWithdrawHook.sol	77.78%	100%	50%	80%	44
umbra-js/src
ethers.ts	76.27%	100%	61.11%	100%
types.ts	50%	100%	0%	100%
umbra-js/src/classes
KeyPair.ts	98.65%	96.49%	100%	100%	31–32
RandomNumber.ts	100%	100%	100%	100%
StealthKeyRegistry.ts	100%	100%	100%	100%
TxHistoryProvider.ts	77.55%	76.47%	66.67%	79.31%	11, 11, 19–20, 31, 38, 44, 53, 57, 8
Umbra.ts	74.24%	61.99%	80.56%	81.57%	102, 128, 131–132, 153, 227–229, 313–316, 378, 386, 386–388, 390–391, 394, 411, 413, 415, 415, 415, 415–416, 416, 416–418, 433, 433, 433–434, 438, 441, 461, 479–480, 567, 584, 597–598, 608–609, 622, 625–626, 656–657, 733, 737, 737, 737–740, 740, 740, 740, 740, 740, 740–741, 741, 741, 741, 741, 741, 741, 741, 741, 741, 741, 743, 743, 743–744, 747, 747, 747, 747, 747–748, 751, 760, 760, 769, 772, 772, 772–774, 787, 791, 794–795, 801–803, 810, 810, 810–813, 844, 849–850, 850–851
umbra-js/src/utils
cns.ts	50%	33.33%	50%	55%	33–36, 40, 40, 40, 40, 40–41, 44–46
constants.ts	100%	100%	100%	100%
ens.ts	36.11%	25%	33.33%	40%	25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
utils.ts	77.34%	68.25%	83.33%	82.89%	108–110, 112–114, 120, 138–139, 168, 186, 239, 246–251, 251, 251, 251, 251, 251, 251–252, 254, 285, 287–288, 297, 297, 297–298, 300, 303, 312–313, 357, 357, 357, 377, 406, 408, 413, 425, 425–426, 431, 433–434, 445–449, 455, 457, 499–500, 500, 500–502, 502, 502, 58–59, 602, 607, 84, 92, 92
umbra-js/test
testPrivateKeys.ts	100%	100%	100%	100%
utils.ts	100%	100%	100%	100%

[mds1]

This PR LGTM. One question: I see you linked #575 here. Now that we're on nodejs 18 which has fetch, is the plan to make the corresponding umbra-js updates in a separate PR, or was that intended for this PR? I think there might only be one typeof window !== 'undefined' check that needs to be removed

[garyghayrat]

This PR LGTM. One question: I see you linked #575 here. Now that we're on nodejs 18 which has fetch, is the plan to make the corresponding umbra-js updates in a separate PR, or was that intended for this PR? I think there might only be one typeof window !== 'undefined' check that needs to be removed

I'll unlink the issue and remove that line in a separate PR! Wanna do some testing to make sure all is well after the changes.