Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wallet libs #588

Merged
merged 21 commits into from
Sep 29, 2023
Merged

Upgrade wallet libs #588

merged 21 commits into from
Sep 29, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Aug 9, 2023

Description

  • Upgrading the libraries improved the UX

Closes #585

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 943000c
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/651431608152e30008051f4e
😎 Deploy Preview https://deploy-preview-588--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexkeating alexkeating marked this pull request as draft August 9, 2023 19:11
umbra-js/tsconfig.json Outdated Show resolved Hide resolved
@alexkeating alexkeating marked this pull request as ready for review August 10, 2023 14:33
@alexkeating alexkeating force-pushed the chore/upgrade-wallet-libraries-3 branch from d739437 to c14c9af Compare August 31, 2023 01:54
@alexkeating alexkeating force-pushed the chore/upgrade-wallet-libraries-3 branch from 6b86440 to fe700af Compare September 11, 2023 17:05
@apbendi apbendi force-pushed the chore/upgrade-wallet-libraries-3 branch 2 times, most recently from b07ce26 to 57cc461 Compare September 25, 2023 16:56
@alexkeating alexkeating force-pushed the chore/upgrade-wallet-libraries-3 branch from 57cc461 to 3549545 Compare September 27, 2023 13:40
@alexkeating alexkeating force-pushed the chore/upgrade-wallet-libraries-3 branch from 3549545 to 943000c Compare September 27, 2023 13:42
@github-actions
Copy link

Coverage after merging chore/upgrade-wallet-libraries-3 into master will be

81.08%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%96
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts75%62.43%82.93%81.95%103, 129, 132–133, 154, 228–230, 314–317, 379, 393, 400–402, 404–405, 408–409, 427, 429, 431, 431, 431, 431–432, 432, 432–434, 449, 449, 449–450, 454, 457, 477, 495–496, 583, 600, 613–614, 624–625, 638, 641–642, 672–673, 749, 753, 753, 753–756, 756, 756, 756, 756, 756, 756–757, 757, 757, 757, 757, 757, 757, 757, 757, 757, 757, 759, 759, 759–760, 763, 763, 763, 763, 763–764, 767, 776, 776, 785, 788, 788, 788–790, 803, 807, 810–811, 817–819, 826, 826, 826–829, 860, 865–866, 866–867
umbra-js/src/typechain
   index.ts70.59%100%37.50%100%
umbra-js/src/typechain/factories
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@OpenZeppelin
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/access
   Ownable__factory.ts50%100%0%66.67%70, 76
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token/ERC20
   ERC20__factory.ts29.03%0%12.50%47.06%310, 314, 314, 314–315, 317, 326, 326, 326, 333, 333, 333, 336, 339, 345
   IERC20__factory.ts50%100%0%66.67%201, 204
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/contracts
   IUmbraHookReceiver__factory.ts50%100%0%66.67%61, 67
   MockHook__factory.ts22.58%0%0%41.18%107, 111, 111, 111–112, 114, 121, 121, 121, 126, 126, 126, 129, 132, 138, 144
   StealthKeyRegistry__factory.ts22.58%0%0%41.18%202, 206, 206, 206–207, 209, 216, 216, 216, 221, 221, 221, 224, 227, 233, 239
   TestToken__factory.ts64.52%66.67%50%70.59%329–330, 348, 351, 354, 360, 366
   Umbra__factory.ts70.97%66.67%62.50%76.47%495–496, 525, 529, 532, 538
   index.ts50%100%0%100%
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts77.81%68.66%86.96%82.91%108–110, 112–114, 120, 138–139, 168, 189, 245, 252–257, 257, 257, 257, 257, 257, 257–258, 260, 291, 293–294, 303, 303, 303–304, 306, 309, 318–319, 345, 363, 363, 363, 383, 412, 414, 419, 431, 431–432, 437, 439–440, 451–455, 461, 463, 505–506, 506, 506–508, 508, 508, 519, 58–59, 762–763, 775–776, 84, 92, 92
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

@apbendi apbendi merged commit 4dc83e3 into master Sep 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Disconnecting Wallet Connect Show Main Connection Modal
3 participants