Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typescript from devDependencies to dependencies #110

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Lhwhatever
Copy link
Collaborator

We need the tsc compiler to build and serve

Description

Fixes failing builds

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

need to check deployment status

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

We need the tsc compiler to build and serve
@railway-app
Copy link

railway-app bot commented Oct 7, 2023

This PR was not deployed automatically as @Lhwhatever does not have access to the Railway project.

In order to get automatic PR deploys, please add @Lhwhatever to the project inside the project settings page.

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for stg-course canceled.

Name Link
🔨 Latest commit 98b78f6
🔍 Latest deploy log https://app.netlify.com/sites/stg-course/deploys/6521b4ed4f236e0009a041ce

@Lhwhatever Lhwhatever assigned Lhwhatever and unassigned Lhwhatever Oct 24, 2023
@Lhwhatever Lhwhatever self-assigned this Oct 24, 2023
@Lhwhatever Lhwhatever requested a review from btwj October 24, 2023 03:15
@Lhwhatever Lhwhatever merged commit 03c7f0d into main Oct 24, 2023
5 checks passed
@Lhwhatever Lhwhatever deleted the honglin/fix-tsc-broken branch October 24, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants