-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): home page, user page and player #116
feat(website): home page, user page and player #116
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/website #116 +/- ##
===================================================
- Coverage 73.97% 73.83% -0.15%
===================================================
Files 220 221 +1
Lines 17538 17608 +70
===================================================
+ Hits 12973 13000 +27
- Misses 4565 4608 +43
|
1fee6b1
to
3c4b289
Compare
a686420
to
dcfb9ef
Compare
bfc9d80
to
bc77ab1
Compare
%sveltekit.head% | ||
</head> | ||
<body data-sveltekit-preload-data="hover"> | ||
<div style="display: contents">%sveltekit.body%</div> | ||
%sveltekit.body% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I believe svelte recommends to have a div wrap around the generated code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it was in the template like this but I couldn't find any reason for the div. Do you know why it's there?
|
||
<style lang="scss"> | ||
@import "../assets/styles/variables.scss"; | ||
@import "../../assets/styles/variables.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use $ path syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any documentation for that syntax. I know it works in svelte script tags but I don't think it works in scss style tags.
@@ -0,0 +1,8 @@ | |||
<script lang="ts"> | |||
export let size: number = 24; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously i did this with rem and fontsize, curious what your thoughts are about that approach? Is this better todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is, as far as I know, I can't apply any styles to the icon from outside of the icon component itself. Which means I would need a wrapper element to apply the styles to which seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm just fix up those few things
We can ignore the audit failure the CVE was dropped today, also LAPIN (the library which is affected, isnt used in my branch anymore since we stopped using RMQ) |
dcb9c4d
to
b1041e3
Compare
- New home page design - New user page design - Player - Chat - Adds `display_color` to user - will be randomly generated when registering - `activeStreamsByUserId` GQL endpoint to fetch all active streams by user id (this may become obsolete with the new data structure soon)
b1041e3
to
ba74188
Compare
Proposed changes
Frontend
Backend
display_color
to useractiveStreamsByUserId
GQL endpoint to fetch all active streams by user id (this may become obsolete with the new data structure soon)Types of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments