Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGDB Categories #189

Merged
merged 6 commits into from
Jan 20, 2024
Merged

IGDB Categories #189

merged 6 commits into from
Jan 20, 2024

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Jan 14, 2024

Proposed changes

Fetch categories from IGDB

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

@TroyKomodo TroyKomodo added platform/api Issues related to the Platform API platform/image-processor Issues related to the Platform Image Processor labels Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 722 lines in your changes are missing coverage. Please review.

Comparison is base (7f57d2f) 46.40% compared to head (1581a17) 45.48%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #189      +/-   ##
===================================================
- Coverage            46.40%   45.48%   -0.92%     
===================================================
  Files                  487      489       +2     
  Lines                31501    32133     +632     
===================================================
- Hits                 14618    14617       -1     
- Misses               16883    17516     +633     
Files Coverage Δ
platform/api/src/database/category.rs 0.00% <ø> (ø)
platform/api/src/database/file_type.rs 0.00% <ø> (ø)
platform/api/src/database/uploaded_file.rs 0.00% <ø> (ø)
platform/image_processor/src/processor/error.rs 0.00% <ø> (ø)
...atform/image_processor/src/processor/job/resize.rs 55.47% <100.00%> (+2.76%) ⬆️
common/src/config.rs 0.00% <0.00%> (ø)
ffmpeg/src/scalar.rs 87.20% <80.00%> (-2.16%) ⬇️
platform/api/src/api/v1/gql/models/category.rs 0.00% <0.00%> (ø)
platform/api/src/api/v1/gql/models/image_upload.rs 0.00% <0.00%> (ø)
platform/api/src/api/v1/gql/subscription/file.rs 0.00% <0.00%> (ø)
... and 10 more

@TroyKomodo TroyKomodo force-pushed the troy/categories branch 3 times, most recently from f0bb543 to 5ebe65c Compare January 18, 2024 14:44
@TroyKomodo TroyKomodo marked this pull request as ready for review January 20, 2024 17:25
@TroyKomodo TroyKomodo requested review from a team as code owners January 20, 2024 17:25
@TroyKomodo TroyKomodo merged commit 8a30bdd into feature/website Jan 20, 2024
6 of 8 checks passed
@TroyKomodo TroyKomodo deleted the troy/categories branch January 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/api Issues related to the Platform API platform/image-processor Issues related to the Platform Image Processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants