Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): favicon #190

Merged
merged 1 commit into from
Jan 14, 2024
Merged

fix(website): favicon #190

merged 1 commit into from
Jan 14, 2024

Conversation

lennartkloock
Copy link
Member

Proposed changes

Turns out the favicon colors were wrong all the time and nobody noticed

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Are we blind?

@lennartkloock lennartkloock requested review from a team as code owners January 14, 2024 21:47
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac1821d) 46.45% compared to head (8bf31a9) 46.44%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #190      +/-   ##
===================================================
- Coverage            46.45%   46.44%   -0.01%     
===================================================
  Files                  486      486              
  Lines                31035    31035              
===================================================
- Hits                 14418    14415       -3     
- Misses               16617    16620       +3     

see 2 files with indirect coverage changes

@lennartkloock
Copy link
Member Author

Thanks codecov, that doesn't make any sense

@lennartkloock lennartkloock merged commit 847737a into feature/website Jan 14, 2024
7 of 8 checks passed
@lennartkloock lennartkloock deleted the lennart/fix-favicon branch January 14, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants