-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove sqlx #192
feat: remove sqlx #192
Conversation
740f97e
to
03197ce
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/website #192 +/- ##
===================================================
- Coverage 46.72% 46.50% -0.22%
===================================================
Files 486 486
Lines 30818 31392 +574
===================================================
+ Hits 14399 14599 +200
- Misses 16419 16793 +374
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried everything and pushed my fixes
Remove SQLx in favor of tokio-postgres. SQLx has had many issues. From the poor design of the query engine to issues with transcations and deserializing. The idea of compile time queries is pretty good but the SQLx implementation is just very sub par. Most features are not supported.
f00ef48
to
17ee76f
Compare
Proposed changes
Remove SQLx in favor of tokio-postgres.
SQLx has had many issues. From the poor design of the query engine to
issues with transcations and deserializing. The idea of compile time
queries is pretty good but the SQLx implementation is just very sub par.
Most features are not supported.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
-/-