Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git repo deps #193

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Remove git repo deps #193

merged 5 commits into from
Jan 17, 2024

Conversation

TroyKomodo
Copy link
Member

Proposed changes

Moves all git repo deps to fixed crates.io crates.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

@TroyKomodo TroyKomodo requested review from a team as code owners January 16, 2024 19:53
This removes opencv as the resizer and switches to a pure rust impl. The
problem with opencv was that it had a dep conflict with `cc` and thus
was causing resolve issues.
@TroyKomodo TroyKomodo requested a review from a team as a code owner January 17, 2024 18:11
@TroyKomodo TroyKomodo merged commit dd59b5b into feature/website Jan 17, 2024
6 of 7 checks passed
@TroyKomodo TroyKomodo deleted the troy/repos branch January 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants