Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): search query #196

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

lennartkloock
Copy link
Member

Proposed changes

Fix search queries. I forgot to test them when reviewing the sqlx refactor pr.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lennartkloock lennartkloock requested a review from a team as a code owner January 18, 2024 21:25
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (54c2f4f) 46.42% compared to head (d48e3f8) 46.42%.

❗ Current head d48e3f8 differs from pull request most recent head 4b133da. Consider uploading reports for the commit 4b133da to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #196      +/-   ##
===================================================
- Coverage            46.42%   46.42%   -0.01%     
===================================================
  Files                  487      487              
  Lines                31489    31489              
===================================================
- Hits                 14619    14618       -1     
- Misses               16870    16871       +1     
Files Coverage Δ
platform/api/src/api/v1/gql/queries/mod.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@TroyKomodo
Copy link
Member

Rebase and you are welcome to merge

@lennartkloock lennartkloock merged commit 0bd56db into feature/website Jan 19, 2024
4 of 5 checks passed
@lennartkloock lennartkloock deleted the lennart/fix-queries branch January 19, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants