Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troy/image processor ext #205

Merged
merged 21 commits into from
Jun 23, 2024
Merged

Troy/image processor ext #205

merged 21 commits into from
Jun 23, 2024

Commits on May 5, 2024

  1. feat: categories

    fix: minor fixes
    
    feat: igdb image processor
    
    fix: proto formatting
    
    feat: handle image callback
    
    fix: lint
    
    fix: push
    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    fe42e47 View commit details
    Browse the repository at this point in the history
  2. fix: formatting

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b4d0544 View commit details
    Browse the repository at this point in the history
  3. fix: scaling calc

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1bd3a2c View commit details
    Browse the repository at this point in the history
  4. fix: into_iter

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a01bbd3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9f6c27f View commit details
    Browse the repository at this point in the history
  6. chore: logs

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3bcfe15 View commit details
    Browse the repository at this point in the history
  7. wd

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    eaae16e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0cd00f5 View commit details
    Browse the repository at this point in the history
  9. chore: rename

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5b7a20f View commit details
    Browse the repository at this point in the history
  10. wd

    TroyKomodo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1f7ce8b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. wd

    TroyKomodo committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0a45f17 View commit details
    Browse the repository at this point in the history
  2. wd

    TroyKomodo committed May 6, 2024
    Configuration menu
    Copy the full SHA
    cc323a6 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Configuration menu
    Copy the full SHA
    d7b3f64 View commit details
    Browse the repository at this point in the history
  2. finish image processor

    TroyKomodo committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ca25465 View commit details
    Browse the repository at this point in the history
  3. remove unused dep

    TroyKomodo committed May 11, 2024
    Configuration menu
    Copy the full SHA
    834cb74 View commit details
    Browse the repository at this point in the history
  4. remove unused dep

    TroyKomodo committed May 11, 2024
    Configuration menu
    Copy the full SHA
    da414e3 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    8a57bf8 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    fac6d5d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Configuration menu
    Copy the full SHA
    9091665 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. fix: remove jemalloc

    We have observed strange behavior with jemalloc causing segfaults within
    the image processor library. We ran the library with libasan and
    valgrind (both incompatiable with jemalloc) and we could not find any
    leaks or invalid memory access or double frees. However when we use
    jemalloc we have issues and sometimes it segfaults always deep inside
    jemalloc code. Since we cannot debug this with valgrind / libasan its
    impossible to figure out if its a problem in our code (more likely) or
    jemalloc (unlikely but possible), given that the bug only comes up when
    we use jemalloc its likely a difference in strictness of the allocator
    and something we are doing is wrong but the system allocator doesnt care
    but jemalloc does.
    
    This issue is also only present when we link directly to jemalloc + use
    jemalloc as the global rust allocator (so it might be an issue in the
    tikv-jemalloc crate). When we use jemalloc via `LD_PRELOAD` the issue
    isnt there.
    TroyKomodo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8eb0aa9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e0b73d View commit details
    Browse the repository at this point in the history