Skip to content

Commit

Permalink
fix build failure
Browse files Browse the repository at this point in the history
Summary:
Building VRS on windows is causing a build failure
```
C:\open\fbsource\arvr\libraries\vrs\vrs\ProgressLogger.h(136): error C2220: the following warning is treated as an error
C:\open\fbsource\arvr\libraries\vrs\vrs\ProgressLogger.h(136): warning C4100: 'precision': unreferenced formal parameter
C:\open\fbsource\arvr\libraries\vrs\vrs\ProgressLogger.h(136): warning C4100: 'duration': unreferenced formal parameter
C:\open\fbsource\arvr\libraries\vrs\vrs\ProgressLogger.h(136): warning C4100: 'operationName': unreferenced formal parameter
```

Reviewed By: georges-berenger

Differential Revision: D53843146

fbshipit-source-id: 5a7b8500f52f184ed2b129155cbe899bc4e9cf3a
  • Loading branch information
Ben Batya authored and facebook-github-bot committed Feb 16, 2024
1 parent b8e8e64 commit fe46daf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion vrs/ProgressLogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ class SilentLogger : public ProgressLogger {
bool logStatus(const string&, int = 0) override {
return true;
}
bool logDuration(const string& operationName, double duration, int precision = 1) override {
bool logDuration(const string& /*operationName*/, double /*duration*/, int /*precision*/ = 1)
override {
return true;
}
};
Expand Down

0 comments on commit fe46daf

Please sign in to comment.