Support producing a FutureRecord for Kafka #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
reviewed
Nov 17, 2023
|
Yes, it looks good. I'd probably also re-export the |
|
@tyt2y3 thank you for the feedback. I've addressed your comments. Let me know if you'd like to see anything else. |
🎉 Released In kafka-0.3.2 🎉Thank you everyone for the contribution! |
|
I just made a minor release, let me know if it works for you! I also added a convenience method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the discussion in #16
The current
sendfunctionality doesn't allow for specifying the key, partition, or headers for Kafka messages. This PR adds asend_recordfunction that allows for specifying aFutureRecorddirectly so that the user can customize the message.@tyt2y3 I'm not 100% sure that this is exactly what you were looking for, but I think it's close. Let me know what you think.