feat: from url and from iterator for streameruri

[carlocorradini]

PR Info

Added From<Url> and FromIterator<Url> for StreamerUri.

• Closes
  • Fix impl From<Url> for StreamerUri #26

New Features

• impl From<Url> for StreamerUri

  let url: Url = "proto://sea-ql.org:1234".parse().unwrap();
  let uri: StreamerUri = url.into();

• impl FromIterator<Url> for StreamerUri

  let urls: [Url; 3] = ["proto://sea-ql.org:1".parse().unwrap() ,"proto://sea-ql.org:2".parse().unwrap(), "proto://sea-ql.org:3".parse().unwrap()];
  let uri: StreamerUri = StreamerUri::from_iter(urls.into_iter());

[carlocorradini]

Unfortunately the following does not compile due to Send (it is required?)

fn connect(
        streamer: impl Into<StreamerUri>,
        options: Self::ConnectOptions,
) -> impl Future<Output = StreamResult<Self, Self::Error>> + Send;

[tyt2y3]

it is possible, if we add Send as a trait bound?

fn connect<S>(
        streamer: S,
        options: Self::ConnectOptions,
) -> impl Future<Output = StreamResult<Self, Self::Error>> + Send
where S: Into<StreamerUri> + Send, {}

[carlocorradini]

Done 🥳

[tyt2y3]

Sad, there was a bunch of errors, where type inference fails.

[carlocorradini]

I'll fix it ASAP.
Sadness... I've run cargo build --all --all-features (same for test) and it worked.

[tyt2y3]

It can be reproduced by cargo test --no-run. May be we change to parse::< StreamerUri >() in all cases

[carlocorradini]

Done 🥳

[tyt2y3]

Thank you