Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchApi tools - return error message instead of an error. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SebastjanPrachovskij
Copy link
Collaborator

Summary

Instead of raising a ValueError with the message Got error from SearchApi: {res['error']}, the SearchApi now directly returns the res['error'] message. This message provides more specific information, such as YouTube Transcripts didn't return any results.. This change was implemented in response to customer complaints.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant