Merge pull request #58 from Sebi94nbg/twitchlive-add-indexerror-try-e…

…xcept Add try-except to better handle invalid API responses
Sebbo94BY · May 14, 2023 · 6781550 · 6781550
2 parents 9123822 + c65f98b
commit 6781550
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/modules/twitch_live/main.py b/modules/twitch_live/main.py
@@ -228,7 +228,6 @@ def get_twitch_streamer_user_id(self, client_description):
         try:
             with request.urlopen(api_request) as api_response:
                 api_response = json.load(api_response)
-                twitch_streamer_user_id = api_response["data"][0]["id"]
         except error.HTTPError as http_error:
             # HTTP 400: Bad Request
             if int(http_error.code) == 400:
@@ -241,8 +240,19 @@ def get_twitch_streamer_user_id(self, client_description):
             TwitchLive.logger.exception("Failed to get a Twitch streamer user ID.")
             raise
 
+        try:
+            twitch_streamer_user_id = api_response["data"][0]["id"]
+        except IndexError:
+            TwitchLive.logger.error(
+                "Received an unexpected API response for the client description `%s`: %s",
+                str(client_description),
+                str(api_response),
+            )
+            return twitch_streamer_user_id
+
         TwitchLive.logger.debug(
-            "Got a Twitch streamer user ID: %s.", int(twitch_streamer_user_id)
+            "Got the following Twitch streamer user ID: %s.",
+            int(twitch_streamer_user_id),
         )
 
         return twitch_streamer_user_id