[Enhancement] Render SeedQR small registration block in solid squares #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK and Tested without issue. I'll review the code at some later time before merging. |
|
ACK tested. super clean, really helps with maintaining orientation while transcribing sectors all around that alignment marker. |
|
Fixes #381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #483
Renders the lower-right registration block in 25x25 and 29x29 SeedQRs as solid squares instead of dots.
Before vs after:
And the same rendering improvement is continued in the zoomed-in transcription UI:
Supplements screenshot generator with:
Briefly tried and quickly gave up on getting the zoomed in transcription UI to render in the screenshot generator (just comes out all black). TODO for another day.