fix: use isFullSegmentImage instead of isImage for AddToSourceSheet b…

…ecause we only want to prohibit full segment images.
Sefaria · Aug 10, 2023 · 9ddae47 · 9ddae47
1 parent d6f0e4f
commit 9ddae47
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/static/js/AddToSourceSheet.jsx b/static/js/AddToSourceSheet.jsx
@@ -132,7 +132,7 @@ class AddToSourceSheetBox extends Component {
     // validate texts corresponding to refs have no images before posting them to sheet
     for (let i = 0; i < refs.length; i++) {
       let ref = Sefaria.getRefFromCache(refs[i]);
-      if (ref && (Sefaria.isImage(ref.he) || Sefaria.isImage(ref.text))) {
+      if (ref && (Sefaria.isFullSegmentImage(ref.he) || Sefaria.isFullSegmentImage(ref.text))) {
         alert("We do not currently support adding images to source sheets.");
         return false;
       }

diff --git a/static/js/sefaria/sefaria.js b/static/js/sefaria/sefaria.js
@@ -1013,10 +1013,6 @@ Sefaria = extend(Sefaria, {
     const pattern = /^\s*<img\b[^>]*>\s*$/i;
     return pattern.test(text);
   },
-  isImage: function(textChunk) {
-    const pattern = /<img\b[^>]*>/i;
-    return pattern.test(textChunk);
-  },
   getRefFromCache: function(ref) {
     if (!ref) return null;
     const versionedKey = this._refmap[this._refKey(ref)] || this._refmap[this._refKey(ref, {context:1})];