18 translation version name in title bar

[b-w-cole]

Description

A test to cover this test case: Sefaria/Sefaria-Playwright-Tests#18

Includes:

• Parameterized tests for all Interface and Source language combinations
• Abstracted source language function for this and future purposes
• New Global variable for source language selection, pointing to DOM locators.

Code Changes

The following changes were made to the files below

Notes

Issue noted with Hebrew sources - the translation title doesn't appear by default. Such cases are commented out in the test parameters.

[b-w-cole]

@saengel , this one isn't quite ready to merge. I'm wondering about your opinion on the file translation-version-name-appears-in-title.spec.ts, and the commented out tests. Do you want me to test for the existence of a default translation title? This will fail for Hebrew source language texts, as the default translation isn't selected in the translation side bar.

[saengel]

@saengel , this one isn't quite ready to merge. I'm wondering about your opinion on the file translation-version-name-appears-in-title.spec.ts, and the commented out tests. Do you want me to test for the existence of a default translation title? This will fail for Hebrew source language texts, as the default translation isn't selected in the translation side bar.

Hi @b-w-cole - thank you again! Another fantastic PR - much appreciated!

I think for Hebrew source language texts, let's keep them commented out for now. Let me know when it's ready for a review.

[b-w-cole]

Hi @saengel ! Sorry for the long wait. I tweaked the Hebrew source language tests to be their own separate test, as the logic needs to be slightly different.

However, I noticed a quirk with the Hebrew Interface / Hebrew Source translations.

1. Load Hebrew Interface and Source text
2. Navigate to Translations
3. Select 'חומש רש״י, רבי שרגא זילברשטיין'
4. 'The Rashi chumash by Rabbi Shraga Silverstein' (in English) will appear in the translation title.

I would expect the Hebrew translation title to appear in the translation title.

Also the source text switches itself to Bilingual.

I will switch this test parameter to Shocken's translation for now and recommit.

[b-w-cole]

Hi @saengel , I was able to consolidate the English and Hebrew tests with a little rearranging. Additionally, I added bilingual support.