Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Allow SPI Calls from inside of Multicorn Python #224

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

RFC: Allow SPI Calls from inside of Multicorn Python #224

wants to merge 62 commits into from

Commits on Aug 17, 2016

  1. Added check for NULL in getRowIDColumn.

    @rbiro
    rbiro committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    fb39f71 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Merge remote-tracking branch 'main/master'

    @rbiro
    rbiro committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7b361d1 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Merge branch 'master' of https://github.com/Kozea/Multicorn

    @rbiro
    rbiro committed May 11, 2019
    Configuration menu
    Copy the full SHA
    e381d74 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Added code to support SPI callbacks as well as release hooks. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    8c6a1c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Removed some debuging code. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    ff731c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2019

  1. Added missing NULL check. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    637bf48 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Latest changes that make calling postgres in the same context mostly … 

    …work.

g
    @rbiro
    rbiro committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    4cb9f0c View commit details
    Browse the repository at this point in the history

  2. Added check for NULL in getRowIDColumn.

    @rbiro
    rbiro authored and Dmitry Bogatov committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    34d80af View commit details
    Browse the repository at this point in the history

  3. Added code to support SPI callbacks as well as release hooks. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro authored and Dmitry Bogatov committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    dc6286f View commit details
    Browse the repository at this point in the history

  4. Removed some debuging code. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro authored and Dmitry Bogatov committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    23a07d9 View commit details
    Browse the repository at this point in the history

  5. Added missing NULL check. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro authored and Dmitry Bogatov committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    5fe8521 View commit details
    Browse the repository at this point in the history

  6. Latest changes that make calling postgres in the same context mostly … 

    …work.

g
    @rbiro
    rbiro authored and Dmitry Bogatov committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    b076cf9 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Remove unused variable from extractColumns()

    Dmitry Bogatov committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    d208b20 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Merge https://github.com/KAction/Multicorn

    @rbiro
    rbiro committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    43c5767 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Commented out free to see if it was a double free. Could lead to a me… 

    …mory leak.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    6503b52 View commit details
    Browse the repository at this point in the history

  2. Try not freeing argtypes. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5732ba7 View commit details
    Browse the repository at this point in the history

  3. Commented out code that actually calls execute to see if that's where… 

    … the crash is.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    7fad456 View commit details
    Browse the repository at this point in the history

  4. Deleted unnecessary iret=0 with missing ; 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    d246b56 View commit details
    Browse the repository at this point in the history

  5. Returned the exec and got rid of a couple of free statements. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    3b5dfb9 View commit details
    Browse the repository at this point in the history

  6. Made multicorn_connect count the number of entries. 

    Turned free and execute back on.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    bc4a7ec View commit details
    Browse the repository at this point in the history

  7. Removed fatal error when multicorn_connect is called more than 1 deep… 

    … (it is called.)

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5aec619 View commit details
    Browse the repository at this point in the history

  8. A bunch of debugging code to find out why it's not reentrant. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c1f00e3 View commit details
    Browse the repository at this point in the history

  9. Moved mylog. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    51e44f9 View commit details
    Browse the repository at this point in the history

  10. Added debug code to connect/disconnect. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    af6f629 View commit details
    Browse the repository at this point in the history

  11. yet more debbuing output. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    ca2eede View commit details
    Browse the repository at this point in the history

  12. Must keep track of both enters and exits to properly 

    connect and disconnect from SPI.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    61d817e View commit details
    Browse the repository at this point in the history

  13. Removed a bunch of debugging log statements. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2576fca View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Commented out plan free in case that's where the double free is. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    ef5e053 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Re-enable some debugging code. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3e94c26 View commit details
    Browse the repository at this point in the history

  2. Debugging code. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    e5c1d72 View commit details
    Browse the repository at this point in the history

  3. Debugging output. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c1a5d79 View commit details
    Browse the repository at this point in the history

  4. Raise an error if we try to execute SQL without being connected to po… 

    …stgres.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5351802 View commit details
    Browse the repository at this point in the history

  5. Moved mylog back to utils so we can actually load it. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    4cdaa24 View commit details
    Browse the repository at this point in the history

  6. Don't disconnect from the SPI. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    75e2053 View commit details
    Browse the repository at this point in the history

  7. Don't free anything. See if crash goes away. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    ad68391 View commit details
    Browse the repository at this point in the history

  8. Turn off execute_plan to see if that's what's causing trouble. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    2911f05 View commit details
    Browse the repository at this point in the history

  9. Turn off the other execute to see if that is what is causing trouble. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    e54c3d8 View commit details
    Browse the repository at this point in the history

  10. commented out logging to /tmp/mylog. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    59c3838 View commit details
    Browse the repository at this point in the history

  11. Raise an exception on unknown type. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    529d6cd View commit details
    Browse the repository at this point in the history

  12. Allow execute to go through again. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    aa06fd2 View commit details
    Browse the repository at this point in the history

  13. spell typename incorrectly. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    df3975a View commit details
    Browse the repository at this point in the history

  14. Allow stmt execute to run again. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5be62aa View commit details
    Browse the repository at this point in the history

  15. Start freeing memory again. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    73eefee View commit details
    Browse the repository at this point in the history

  16. Don't free individually, ust the whole connection. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    369c795 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Check for dropped attributes, invalid, types and bad lengths before 

    trying to convert from python to a datum.

--------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1fc33d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Removed assumption that select tuples match the table. 

    Apparently they do not any more.
Added some asserts to catch the related problems
early.
    @rbiro
    rbiro committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    7f99678 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. When the tupdesc changes, warn and recompute the cinfo. 

    --------- BEGIN META VARIABLES --------
Project :
Task :
Done :
--------- END META VARIABLES --------
    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    e6fa705 View commit details
    Browse the repository at this point in the history

  2. Converted Assert to an error with some useful info. So at least we 

    shouldn't crash and we should get some information to help with
debugging.
    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    306d039 View commit details
    Browse the repository at this point in the history

  3. Switch from repalloc NULL to palloc and cleanup warning for nameData.

    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    58d5588 View commit details
    Browse the repository at this point in the history

  4. Don't test for attlen < 0, variable length fields apparently use that.

    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0a9b781 View commit details
    Browse the repository at this point in the history

  5. Added some debugging code and made sure the key and attribute name ma… 

    …tch.
    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8482e46 View commit details
    Browse the repository at this point in the history

  6. Comment potential problem in multicorn.c. 

    Check for key being NULL before trying to print it.
    @rbiro
    rbiro committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0dd4e5b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Comment out SPI_Fiish to see if it's a use after free problem.

    @rbiro
    rbiro committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4e20c25 View commit details
    Browse the repository at this point in the history

  2. Fixed spelling of NULL.

    @rbiro
    rbiro committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    6fe4795 View commit details
    Browse the repository at this point in the history

  3. Try reinitializing cinfos every iteration.

    @rbiro
    rbiro committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2636e6b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Merge ../Multicorn.upstream

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    1422cdb View commit details
    Browse the repository at this point in the history

  2. Raise an error when we can't load our module.

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    c1048c2 View commit details
    Browse the repository at this point in the history

  3. Use the provided storage for NULLs and values.

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    b8ab065 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:rbiro/Multicorn

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    f823a95 View commit details
    Browse the repository at this point in the history

  5. Force cinfos to be realloc everytime. See what that does to the crashes.

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    814569b View commit details
    Browse the repository at this point in the history

  6. Remove call to spi_connect since our test doesn't need it.

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    90b4278 View commit details
    Browse the repository at this point in the history

  7. Check for a missing relid for the foreign table.

    @rbiro
    rbiro committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    d711326 View commit details
    Browse the repository at this point in the history