Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure tags are available in the initial pipeline #94

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 16, 2023

Contributor Comments

This ensures that tags are available in the initial pipeline. There are three changes:

  1. Change the lightweight initial tag to an annotated tag, required for --follow-tags and this also ensures it's aligned with future release tags, which are annotated.
  2. Update the docs to push the initial commit with --follow-tags which will push the initial release hook which is created as a part of the post-creation hook.
  3. Update the github actions workflow to have a fetch depth of the whole repo for the build/test stage. This is needed so the build step knows which docker image tag to use (which is dynamic and based on a combination of version details from the project and the git tags)

This depends on SeisoLLC/goat#160

Pull Request Checklist

Thank you for submitting a contribution to cookiecutter-python!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla marked this pull request as draft August 16, 2023 13:48
@JonZeolla JonZeolla added the blocked Unable to make progress label Aug 19, 2023
@JonZeolla JonZeolla marked this pull request as ready for review August 19, 2023 10:24
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JonZeolla JonZeolla merged commit 4ce9892 into main Aug 21, 2023
3 checks passed
@JonZeolla JonZeolla deleted the fix/annotate-and-push-tag branch August 21, 2023 16:56
@JonZeolla JonZeolla removed the blocked Unable to make progress label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants