Skip to content

Commit

Permalink
Shorten flag description
Browse files Browse the repository at this point in the history
  • Loading branch information
vtaskow committed Jul 21, 2023
1 parent 262ca74 commit f50f63e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion mlserver/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ class Config:

# Logging settings
use_structured_logging: bool = False
"""Use JSON-formatted structured logging instead of default human-readable format."""
"""Use JSON-formatted structured logging instead of default format."""
logging_settings: Optional[Union[str, Dict]] = None
"""Path to logging config file or dictionary configuration."""

Expand Down
3 changes: 3 additions & 0 deletions tests/test_logging.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import pytest
import json


from mlserver import ModelSettings
from mlserver.context import model_context
Expand Down Expand Up @@ -108,6 +110,7 @@ def test_model_logging_formatter_structured(
logger.info("Inside model context")
logger.info("After model context")

_ = [json.loads(lr) for lr in caplog.text.strip().split("\n")]
log_records = caplog.get_records("call")
assert len(log_records) == 3

Expand Down

0 comments on commit f50f63e

Please sign in to comment.