Add Japanese language dependencies #1511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyono
approved these changes
Dec 12, 2023
sakoush
requested changes
Dec 12, 2023
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
|
@sakoush I believe I have addressed your comments. Let me know if I have misunderstood something! |
sakoush
requested changes
Dec 15, 2023
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
sakoush
requested changes
Dec 26, 2023
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py
Outdated
Show resolved
Hide resolved
|
@sakoush Hey! Hope your holidays went well. Just bumping this to your attention because I think it's ready if not close to ready to merge. Let me know if I misunderstood some of your comments. Looking forward to your feedback. |
sakoush
reviewed
Jan 16, 2024
jyono
approved these changes
Jan 16, 2024
|
Hey @sakoush , the pipeline is failing on TF v2.14 dropping support for Python 3.8. Would you rather drop support for Python 3.8 for this runtime or have me deprecate TF to v2.13? |
…ldonIO#1692) Bumps [joblib](https://github.com/joblib/joblib) from 1.3.2 to 1.4.0. - [Release notes](https://github.com/joblib/joblib/releases) - [Changelog](https://github.com/joblib/joblib/blob/main/CHANGES.rst) - [Commits](joblib/joblib@1.3.2...1.4.0) --- updated-dependencies: - dependency-name: joblib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eldonIO#1695) Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@jbauer2718 it looks like that merge conflicts have not been resolved correctly, at least by looking at the changes in |
|
@sakoush Sorry for missing that. Should be good now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1506