Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Bump to Bazel 8.0.1 #15140

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

[bazel] Bump to Bazel 8.0.1 #15140

wants to merge 2 commits into from

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Jan 23, 2025

PR Type

Enhancement, Configuration changes


Description

  • Updated Bazel version to 8.0.1 in .bazelversion.

  • Adjusted .bazelrc configuration for compatibility with Bazel 8.0.1.

  • Removed unused file patterns in Bazel build files for Java and JavaScript.


Changes walkthrough 📝

Relevant files
Configuration changes
.bazelrc
Updated `.bazelrc` for Bazel 8.0.1 compatibility                 

.bazelrc

  • Added --lockfile_mode=off to disable lockfile usage.
  • Introduced --enable_workspace and
    --incompatible_disallow_struct_provider_syntax=false.
  • Adjusted configurations for Closure rules compatibility.
  • +4/-1     
    Enhancement
    .bazelversion
    Bumped Bazel version to 8.0.1                                                       

    .bazelversion

    • Updated Bazel version from 7.4.1 to 8.0.1.
    +1/-1     
    BUILD.bazel
    Cleaned up Java Bazel build file                                                 

    java/src/org/openqa/selenium/grid/session/BUILD.bazel

    • Removed remote/*.java from source file glob pattern.
    +0/-1     
    BUILD.bazel
    Cleaned up JavaScript Bazel build file                                     

    javascript/grid-ui/BUILD.bazel

    • Removed public/**/* from source file glob pattern.
    +0/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change

    Disabling lockfile mode could lead to inconsistent dependency versions across builds. The commented rationale mentions Git conflicts, but this should be carefully validated.

    common --lockfile_mode=off
    Compatibility Flag

    The added flag '--incompatible_disallow_struct_provider_syntax=false' suggests backward compatibility issues. Need to verify if this is a temporary workaround or a long-term solution.

    common --incompatible_disallow_struct_provider_syntax=false

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Replace deprecated workspace flag

    The --enable_workspace flag is deprecated and may be removed in future Bazel
    versions. Consider using --enable_bzlmod instead for module support.

    .bazelrc [10-14]

     common --lockfile_mode=off
     
     # Required for the Closure rules
    -common --enable_workspace
    +common --enable_bzlmod
     common --incompatible_disallow_struct_provider_syntax=false
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies that --enable_workspace is deprecated and proposes using --enable_bzlmod instead, which is the recommended approach for module support in Bazel. This change helps future-proof the codebase.

    8

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant