Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/gpg vks #18

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

WIP: Feature/gpg vks #18

wants to merge 16 commits into from

Conversation

Cellebyte
Copy link
Collaborator

@Cellebyte Cellebyte commented Mar 11, 2020

This needs some further development and is not releaseable in the current state.

@Cellebyte Cellebyte changed the title WIP: Feature/gpg vks Feature/gpg vks Mar 11, 2020
@Cellebyte Cellebyte changed the title Feature/gpg vks WIP: Feature/gpg vks Mar 11, 2020
@vollkorn1982
Copy link
Contributor

I can search and download keys without a problem, but adding keys to the keyserver does not seem to work with the gpg-vks branch. No error message at all, but I do not get an e-mail for verification of the upload. I'll need to dig deeper into this to figure out what's happening and look at the HTTPS traffic, I guess.

@Valodim
Copy link

Valodim commented May 8, 2020

can recommend mitmproxy to debug this kind of thing :)

@Cellebyte
Copy link
Collaborator Author

Cellebyte commented May 8, 2020

@Valodim @vollkorn1982 I don't tested the add functionality of the vks-protocol so far.
I will also look into it after work. ^^

@vollkorn1982
Copy link
Contributor

Good news: add() was successful. The key confirmation e-mails were just stuck in grey-listing for a long time. I received them now.

Therefore, I conclude: This branch works fine for me :)

@Valodim
Copy link

Valodim commented May 8, 2020

Actually, it seems like the add() call only uses /pks/add. That will only work for an initial upload of the key, HKP just isn't meant for that workflow so we can't really use it for verification. see https://keys.openpgp.org/about/api for details

@Cellebyte
Copy link
Collaborator Author

Actually, it seems like the add() call only uses /pks/add

/vks/v1/upload is also possible will add that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants