-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): closing the search menu on spacebar press #3766
fix(Dropdown): closing the search menu on spacebar press #3766
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3766 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 175 175
Lines 3125 3125
=======================================
Hits 3120 3120
Misses 5 5
Continue to review full report at Codecov.
|
👍 Thanks for getting this done so fast! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the right quick fix for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in manually, works like a charm 💎
Thank you for fixing this ❤️
Fixes the #3764 .
In tests, I've only focused on open/closed state of the Dropdown components, because
DropdownItem
gets automatically setactive
andselected
, which is probably a different issue (#3130 ), so I decided not to dig into it.