Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated AFMV FIX #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated AFMV FIX #13

wants to merge 2 commits into from

Conversation

travisliu3
Copy link

Thanks for taking the time to contribute to GCC! Please be advised that if you are
viewing this on github.com, that the mirror there is unofficial and unmonitored.
The GCC community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Please send patches there instead.

for (i = 0; i < attrnum; i++)
{
char *attr = attrs[i];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems like it would break attributes normally?
You're not parsing attrs[i] anymore and you're replacing it with your own.

Can you create a copy of the attrs char array and add the two extra strings for sve and sve2?

Copy link
Collaborator

@code-Gambler code-Gambler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 348 the array is initialized
char **attrs = XNEWVEC (char *, attrnum);
now instead of initializing it with attrnum you can initialize it with attrnum + 2 and after that append the array with "sve" and "sve2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants