Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppressing warnings #5

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Suppressing warnings #5

merged 1 commit into from
Jan 16, 2024

Conversation

matsujirushi
Copy link
Contributor

  • SensirionRxFrame.cpp:58:12: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  • SensirionRxFrame.cpp:75:12: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  • SensirionRxFrame.cpp:112:20: warning: 'convert' may be used uninitialized in this function [-Wmaybe-uninitialized]

Seeed-Studio/Wio_Tracker_1110_Examples#18

@evtimDev
Copy link

Looks good to me.

@evtimDev
Copy link

We are hitting these warnings and don't want to disable the treat warnings as errors for our build. Can we get this merged?

@Zifzaf @rnestler

rnestler
rnestler approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not working for Sensirion anymore so don't have access to this repository. @psachs?

@psachs psachs merged commit b43eb48 into Sensirion:main Jan 16, 2024
@KillingJacky KillingJacky mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnestler rnestler rnestler approved these changes

@psachs psachs psachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matsujirushi @evtimDev @psachs @rnestler