Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Nuget packages in some samples #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating Nuget packages in some samples #3

wants to merge 1 commit into from

Conversation

brgrz
Copy link

@brgrz brgrz commented May 5, 2013

fixed two lines of code in CustomAuthenticationMvc to work with latest SS

fixed two lines of code to work with latest SS
@mythz
Copy link
Member

mythz commented May 5, 2013

thx, but there's a whitespace/new-line issue that shows this pull-request has modified every file.
You might have to re-clone from master to be able to send a clean pull-request.

@brgrz
Copy link
Author

brgrz commented May 5, 2013

hm, here the 56 modified files are depicted fine https://github.com/mhrovatic/ServiceStack.UseCases/commit/7d961bfdddbc5c71146846106e54ff0ca8125dd8

I don't know how to do it differently. I fork a project, clone my fork with GitHub for Windows, work on it, then commit and sync. Then I did pull request from the GitHub user interface.

@mythz
Copy link
Member

mythz commented May 5, 2013

If it's not already, try again with autocrlf set to off, e.g:

git config --global core.autocrlf false

If the issue still exists, can you point to the lines that have changed and I can just apply the changes on my end.

@brgrz
Copy link
Author

brgrz commented May 5, 2013

Demis, I ran this locally but now I don't know how to make a new commit with this setting in place and a fresh pull request. You might want to update the code yourself.

The only thing I did is update all packages besides jQuery in the Manage Nuget packages dialog window and then add

using Servicestack;

to the usings list in Account and Home controllers so that ToRequestContext() was being found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants