Skip to content

Commit

Permalink
Merge pull request #183 from Seshat-Global-History-Databank/add-docs-…
Browse files Browse the repository at this point in the history
…preview-to-docs

Update documentation build instructions to include docs preview
  • Loading branch information
edwardchalstrey1 authored Nov 25, 2024
2 parents b7c707f + c1c8259 commit c3088b6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion docs/source/how-to-update-these-docs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Once you have these pre-requisites, you can follow the steps below to update the

- If adding new pages, ensure they are added to the "toctree" at the top of the `index.rst` file present in the same directory.

5. [Optional] Build the documentation locally to check that your changes are rendering correctly.
5. [Optional] Build the documentation locally to check that your changes are rendering correctly. Note: when opening a pull request in the last step you will be able to see a preview of the changes on GitHub anyway, but this could be quicker if you have a lot of changes to check.

- Install the required dependencies for building the documentation. You may wish to use a virtual environment to avoid conflicts with other Python packages.

Expand Down Expand Up @@ -118,6 +118,11 @@ Once you have these pre-requisites, you can follow the steps below to update the

- Click "Create pull request" and add a descriptive title and description to the pull request.

- The documentation will be built automatically and you will be able to see a preview of the changes on the pull request page. Click "Details".

.. image:: img/PR_docs_preview.png
:alt: Docs preview

- A Seshat Databank Admin will review your changes and may request further changes before merging the pull request.

- Once your pull request is merged, the changes will take a few moments before being reflected on this website.
Binary file added docs/source/img/PR_docs_preview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit c3088b6

Please sign in to comment.