-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing GitHub Actions to reflect the GitHub user + updating some references #26
base: dev
Are you sure you want to change the base?
Changing GitHub Actions to reflect the GitHub user + updating some references #26
Conversation
Adding in all recent edits
See conversation in #18 |
@@ -18,18 +18,24 @@ on: | |||
jobs: | |||
build: | |||
runs-on: ubuntu-latest | |||
permissions: write-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly googling ERROR: denied: installation not allowed to Write organization package
and the suggestion is to update these permissions to write-all
as you already have done - so not sure there, but otherwise everything LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not working, so I need to work more on this!
With this change do you think we even require a doc for #18 ? My original motivation was so any future developers knew how to change the token if I was not working on the project anymore, but that might no longer be an issue |
That's my hope! |
@kallewesterling are you still working on this or should I take over? Looks like where we left it it the |
What I have done:
secrets.GH_TOKEN
to the automaticsecrets.GITHUB_TOKEN
seshat-global-history-databank/seshat
to a variable${{ github.actor }}/seshat
instead, which allows for forks to run builds + tests automatically as well