Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA - DO NOT MERGE] Visualise uncertainty by differential blurring of polity shapes #43

Closed
wants to merge 34 commits into from

Conversation

edwardchalstrey1
Copy link

@edwardchalstrey1 edwardchalstrey1 commented Jul 23, 2024

This PR is a first attempt towards #20

Visualising uncertainty

  • Adds a "confidence" field which takes values of 1, 2 or 3. Where 1 indicates a border shape is 'Approximate', 2 means 'Moderately precise' and 3 means 'Determined by international law'.
  • Sets the amount of blur applied to shapes (on polity pages and the world map) based on the confidence score, with 1 being the most blurry and 3 the least. Where the confidence field is not filled in (in every case currently), there are confidence values set by some logic based on the polity start year:
    • If polity start year is less than 0: confidence = 1 | If polity start year is greater than 0 and less than 1500: confidence = 2 | If polity start year is greater than 1500: confidence = 3
  • On Polity pages (and crucially on the edit page), you can click a polity to reveal it's ID number and confidence score, and also there's a button to show all the shapes with their respective IDs and confidence scores. This provides a way to indicate a shape when suggesting edits to the confidence via the existing edit mechanism

Other changes

  • Renames the Videoshapefile model to Cliopatria
  • The legend no longer scrolls of screen when you click many polities, instead it becomes scrollable

Reviewers

Take a look at the world map now and notice how it looks different, with the blur levels of shapes based on the uncertainty scoring as outlined above.

This change is the most noticeable on the world map but is also applied on individual Polity pages.

Here are some Polity page examples for each of the confidence levels:
Seleucids (1)
Roman Empire - Dominate (2)
Republic of China (3)

@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review July 26, 2024 11:15
@kallewesterling
Copy link
Member

@edwardchalstrey1 I think I can see this all on the dev server, which may be the easiest way for me to look at this without having to migrate my local database before we've merged the edits.

It looks good, I think, but I'm not loving the blurriness. I wonder if we should run this by the larger team, and if there's a better way to show the uncertainty? Maybe by creating dashed borders or something?

@edwardchalstrey1
Copy link
Author

@edwardchalstrey1 I think I can see this all on the dev server, which may be the easiest way for me to look at this without having to migrate my local database before we've merged the edits.

It looks good, I think, but I'm not loving the blurriness. I wonder if we should run this by the larger team, and if there's a better way to show the uncertainty? Maybe by creating dashed borders or something?

Fair enough! Yes, I've emailed Pieter, Peter and Jim on the 26th July but haven't had any responses yet - perhaps I'll but the word out on the Data/Culture channel too

@edwardchalstrey1 edwardchalstrey1 marked this pull request as draft August 5, 2024 13:41
@edwardchalstrey1 edwardchalstrey1 changed the title Visualise uncertainty Visualise uncertainty by blurring polity shapes Aug 5, 2024
@edwardchalstrey1 edwardchalstrey1 changed the title Visualise uncertainty by blurring polity shapes Visualise uncertainty by differential blurring polity shapes Aug 5, 2024
@edwardchalstrey1 edwardchalstrey1 changed the title Visualise uncertainty by differential blurring polity shapes Visualise uncertainty by differential blurring of polity shapes Aug 5, 2024
@rwood-97
Copy link
Collaborator

rwood-97 commented Aug 6, 2024

lgtm :)

@kmcdono2
Copy link

kmcdono2 commented Aug 6, 2024

Do you think the 1-3 uncertainty score works well?

Where the confidence field is not filled in (in every case currently), there are confidence values set by some logic based on the polity start year:
If polity start year is less than 0: confidence = 1 | If polity start year is greater than 0 and less than 1500: confidence = 2 | If polity start year is greater than 1500: confidence = 3

Uncertainty based only on date of polity "start" is a) not the only kind of uncertainty, b) unclear for whom there is uncertainty and c) why there is uncertainty. Simply being 'old' is not the source of uncertainty for most frontiers/borders. Are there other attributes for polities that could complicate how uncertainty is assigned? E.g. how many sources attest this border geometry? How reliable are those sources?

Do you think the different blur levels work well to illustrate this?

One of the problems with using vector polygons to represent historical polities is that the concept of the border as a defined line in the landscape simply does not exist in most parts of the world before the 19th c. Blur helps communicate the idea of a frontier space, which is more accurate for most cultures, but how much should be 'solid' and how wide should the 'blur' be? Also the idea that polities have the same level of control over everything 'within' the polygon is a fiction, and the blur on the edges doesn't communicate this.

How would you set the default years for the uncertainty scores?

I don't think years are the main issue in determining uncertainty (see above).

@PieterFrancois
Copy link

Hi Ed,

Good to see this progress.

A few quick observations from me:

  • Not fully sold on using years as the main arbiter of uncertainty. I think we need to go to all our experts and ask them for a number (o, 1, 2, and 3) which means we need agreement and guidelines on what these mean so that there is rough comparability between the codes. This also allows for different experts present us with different numbers and we should capture this. That way the spatial data is in line with all our other data.
  • I am OK with using blur at the edges as a shorthand for 'be careful to treat these lines as well delineated and set in stone'. The intellectual reservations are well known but at the same time we want to do more than throw our hands up in the air. In the methodology paper I will have to explain this clearly and we also need to find a way to communicate this well and prominently on the website. However, I don't particularly like the specific blurness. Could you keep the centre clear and use for the border areas a sort of zebra crossing look with one colour the colour of the polity and one colour to signify the level of uncertainty (e.g. white for a bit of uncertainty and dark grey for a lot of uncertainty).

FYI: Do not wait for Peter's input on this as he is out of action for a while.

Best,
Pieter

@edwardchalstrey1
Copy link
Author

Thanks for your input on this everyone - ok, I think this requires further discussion rather than merging right away - I'll put it on the agenda for the Seshat meeting next week

Copy link
Member

@kallewesterling kallewesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, following our conversation this week, that there is some more experimentation that needs to happen around the visual representation, but otherwise, the implementation looks good to me.

@edwardchalstrey1 edwardchalstrey1 changed the title Visualise uncertainty by differential blurring of polity shapes [IDEA - DO NOT MERGE] Visualise uncertainty by differential blurring of polity shapes Aug 29, 2024
@edwardchalstrey1 edwardchalstrey1 added the wontfix This will not be worked on label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants