Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong comments about destination token in tradeModule.spec.ts #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gzliudan
Copy link
Contributor

Below two comments of // Get random source token should be // Get random destination token:

        describe("when receive token does not match calldata", async () => {
          beforeEach(async () => {
            // Get random source token
            const randomToken = await getRandomAccount();
            subjectData = zeroExMock.interface.encodeFunctionData("transformERC20", [
              sourceToken.address, // Send token
              randomToken.address, // Receive token
              sourceTokenQuantity, // Send quantity
              destinationTokenQuantity.sub(ether(1)), // Min receive quantity
              [],
            ]);
          });

          it("should revert", async () => {
            await expect(subject()).to.be.revertedWith("Mismatched output token");
          });
        });

and

        describe("when receive token does not match calldata", async () => {
          beforeEach(async () => {
            // Get random source token
            const randomToken = await getRandomAccount();
            subjectData = zeroExMock.interface.encodeFunctionData("transformERC20", [
              sourceToken.address, // Send token
              randomToken.address, // Receive token
              sourceTokenQuantity, // Send quantity
              destinationTokenQuantity.sub(ether(1)), // Min receive quantity
              [],
            ]);
          });

          it("should revert", async () => {
            await expect(subject()).to.be.revertedWith("Mismatched output token");
          });
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants