Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set undefined attribute values to null if missingIfNull flag is set. Ignore other falsy values. #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set undefined attribute values to null if missingIfNull flag is set. Ignore other falsy values. #242

wants to merge 1 commit into from

Conversation

hinsenchan
Copy link

Fixes the falsy value bug from this issue:
#241

@hinsenchan
Copy link
Author

@SeyZ was wondering what you thoughts are on this PR?

The issue is that all falsy JavaScript attribute values are getting set to null if nullIfMissing flag is set. I would like boolean false values to remain false.

Issue created for this PR: #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hinsenchan