Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wayland implementation and basic dbus method to take screenshot #13

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

Ericky14
Copy link
Collaborator

@Ericky14 Ericky14 commented Dec 23, 2024

Added wayland manager and dbus interface with take_screenshot method

Wayland manager initializes if gamescope sockets are detected at /run/user/{userId}/gamescope-*

Command to take screenshot:

busctl --user call org.shadowblip.Gamescope /org/shadowblip/Gamescope/Wayland0 org.shadowblip.Gamescope.Wayland TakeScreenshot sy "/tmp/foo.png" 0

@Ericky14 Ericky14 requested a review from ShadowApex December 23, 2024 17:11
@Ericky14 Ericky14 force-pushed the feat/wayland-screenshot branch from 0290fc1 to 0aa2a10 Compare December 23, 2024 17:13
pending::<()>().await;

Ok(())
signal::ctrl_c().await?;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified this because sometimes when exiting gamescope-dbus with ctl_c, the dbus interface name was stuck registered, seemed like the process wasn't exiting properly

src/gamescope/manager.rs Outdated Show resolved Hide resolved
src/gamescope/wayland/manager.rs Outdated Show resolved Hide resolved
src/gamescope/wayland/manager.rs Show resolved Hide resolved
src/gamescope/xwayland.rs Show resolved Hide resolved
@Ericky14 Ericky14 requested a review from ShadowApex December 23, 2024 20:55
Copy link
Contributor

@ShadowApex ShadowApex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ShadowApex ShadowApex merged commit e08c502 into main Dec 23, 2024
2 checks passed
@ShadowApex ShadowApex deleted the feat/wayland-screenshot branch December 23, 2024 21:21
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
# [1.7.0](v1.6.0...v1.7.0) (2024-12-23)

### Features

* **Wayland:** add wayland implementation and basic dbus method to take screenshot ([#13](#13)) ([e08c502](e08c502))
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants