Rewrite SScript Implementation #12922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moxie-coder
approved these changes
Jul 29, 2023
ghost
approved these changes
Jul 29, 2023
Intancote
approved these changes
Jul 29, 2023
Joalor64GH
approved these changes
Jul 29, 2023
cyn0x8
approved these changes
Jul 30, 2023
charlesisfeline
approved these changes
Jul 30, 2023
|
this seems to have broken scripts that use runHaxeCode more than once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites most of the SScript implementation.
(Resolved the conflicts)
doString, HScript uses nownewwhich is better optimized.doStringchange,runHaxeCodecan now use files.getTextFromFileis unnecessary.runHaxeCodenow can return values without a function.destroy().globalis used to check for conflicting scripts.callOnHScript, which fixes not being able to call the same function from multiple scripts.interpNamewithoriginwhich is used for Lua traces.addHaxeLibrarynow doesn't initialize Haxe scripts for its Lua script, so you can use it after or beforerunHaxeCode.